Onboard query-helper to Backstage - #70
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Not ready to approve
The new Backstage entity descriptor is missing key spec fields (owner/lifecycle) needed for reliable catalog validation/display.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Adds a Backstage catalog entity descriptor so query-helper can be discovered and managed in the Backstage software catalog.
Changes:
- Introduces a
backstage.yamlComponententity definition for the repository. - Populates basic metadata (name, description, annotations, labels) and sets component type/system.
File summaries
| File | Description |
|---|---|
| backstage.yaml | Adds a Backstage Component entity descriptor for catalog onboarding. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| kind: Component | ||
| metadata: | ||
| name: query-helper | ||
| description: 'A Onboard an Existing Repo to Backstage created via Backstage' |
Comment on lines
+15
to
+17
| spec: | ||
| type: service | ||
| system: pxm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
backstage.yamlcatalog descriptor so this repo appears inthe Backstage catalog.
Opened automatically by the Onboard an Existing Repo to Backstage
scaffolder template.