chore: staging/pfv6#3134
Open
zeroedin wants to merge 21 commits into
Open
Conversation
chore: replace web-dev-server with cem serve
🦋 Changeset detectedLatest commit: 261e220 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
* chore(tools): update tooling config for v6 prefix - Generalize eslint ignore glob for icon demo path to match both pf-v5-icon and pf-v6-icon directories - Update eslint no-missing-package-exports rule to match only pf-v6-* element directories - Remove all pf-v5-* export entries from elements/package.json since v6 release will not ship v5 elements - Bump elements package version to 6.0.0-next.0 Audited and confirmed no changes needed in: - tsconfig files (no v5-specific paths) - web-test-runner.config.js (generic globs) - playwright.config.ts (generic globs) - commitlint.config.js (already handles both prefixes dynamically) Closes #3130 Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: custome-element.json output location * chore: add settings.local.json to gitignore * chore: remove extra cem config * chore: revert package.json version * chore: revert eslint config * chore: remove no-missing-package-exports altogether * chore: splat exports * docs: delete migration plan it's now in the issue body for epic #3110 * chore: update cem configs * chore: update cem --------- Co-authored-by: Benny Powers <web@bennypowers.com>
Contributor
Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chore(deps): bump @pwrs/cem to 0.10.5
Contributor
* chore: remove v5 element after update * docs: apply suggestion from @bennypowers --------- Co-authored-by: Benny Powers <bennypowers@users.noreply.github.com>
Contributor
Contributor
Contributor
Add Phase 8 (README) to create-element and update-element skills, instructing agents to produce a divergences-from-React document for each element. Three tables: not implemented, changed API, and added. Includes accuracy rules to prevent false claims about shadow DOM. References elements/pf-v6-tooltip/README.md as example. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
docs(create-element): add README phase to element skills
Contributor
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "chore: staging/pfv6"
} |
…ap (#3144) The `.js` regex in `liveReloadTsChangesMiddleware` was not end-anchored, so requests for `.js.map` (source maps) were matched and rewritten to `.ts.map`, breaking source maps in the dev server. End-anchor the regex (`\.js$`) and use a regex replacement so only the final `.js` extension is rewritten to `.ts`. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
* fix(tools): support tagPrefix as an array of tags * chore(tools): add changeset * refactor(tools): extract getPrefixes/matchPrefix helpers from callsites Centralizes prefix normalization into two helpers in config.ts: - `getPrefixes()`: normalizes tagPrefix to non-empty array, throws on empty - `matchPrefix()`: finds matching prefix for a tag name with trailing dash All callsites (DocsPage, Manifest, test config, deslugify) updated to use helpers instead of inline `[].flat()` normalization, addressing Copilot review feedback about `prefixes[0]` being undefined when tagPrefix is an empty array. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor(tools): re-export DemoRecord from Manifest instead of duplicating The DemoRecord interface in 11ty/plugins/types.ts was a separate copy from the canonical one in Manifest.ts. Re-export it to maintain a single source of truth. The CJS plugin's JSDoc type annotation still resolves correctly. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test(tools): add unit tests for getPrefixes, matchPrefix, deslugify Covers edge cases: empty array, undefined tagPrefix, empty string filtering, prefix matching/fallback, trailing dash normalization, and multi-prefix deslugify behavior. Uses node:test + node:assert, run via `npx tsx --test`. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(tools): exclude node-only spec files from WTR config.spec.ts uses node:test and node:assert, which cannot run in WTR's browser context. Exclude tools/pfe-tools/*.spec.ts from the WTR file glob. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Benny Powers <web@bennypowers.com>
Contributor
…round-image` (#3151) * feat(background-image): port pf-v5-background-image to pf-v6-background-image * test(background-image): remove unecessary tests * fix(background-image): remove reflection on src * fix(background-image): css tweak * chore(background-image): add changeset
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Testing Instructions
Notes to Reviewers