refactor: deduplicate constants and error helper in managedInstall#125
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Extract MANAGED_INSTALL_UNAVAILABLE constant, PROGRESS_OPTIONS constant, and errorMessage() helper used identically across installPatchloom, updatePatchloom, and reinstallPatchloom. Reduces 3x duplication of each pattern to a single definition at module scope. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
force-pushed
the
fix/deduplicate-managed-install
branch
from
312905d to
739d7d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract three patterns duplicated across
installPatchloom,updatePatchloom, andreinstallPatchloom:MANAGED_INSTALL_UNAVAILABLEconstant (was duplicated on lines 33, 79, 158)PROGRESS_OPTIONSconstant (was duplicated on lines 47-52, 93-98, 182-187)errorMessage()helper (was duplicated on lines 68, 147, 203)Net: -21 lines removed, +22 lines added (constants and helper at module scope).
All 249 tests pass, coverage thresholds met, package builds cleanly.