fix: opening MOVE drags ride the node's own wall; one undo entry per gesture

[Snoopy147]

Two defects in the door/window MOVE experience with the X-ray active, found by full-stack visual QA after #689:

A — wrong-wall capture. #689 keeps every hidden wall a ray target while a wall-opening tool is active. During a MOVE, the nearest hidden wall along the cursor ray could be an interposed wall between the camera and the dragged node's own wall — the drag silently rode it and the commit re-parented the opening onto a wall the user cannot see (API-verified repro: window re-parented from its own wall to an invisible shed wall). Fix: while moving an existing opening, wall events from HIDDEN walls are ignored unless they come from the node's own wall (original or current mid-drag host). Ignored events don't stop propagation, so the own wall behind emits its own event and the drag keeps riding it. Cross-wall re-parenting still works — onto visible walls (an explicit target). PLACE and duplicate placement keep the all-walls behavior; X-ray drags along the node's own hidden wall keep working (#689's intent).

B — multi-entry undo. A completed door drag produced multiple undo entries, none of which restored the pre-drag state. Root cause: the move tools' raw temporal.pause() is invisible to the refcounted getSceneHistoryPauseDepth(); zundo reads isTracking after a write's subscribers run, so the space-detection sync's balanced pause/resume pair (woken by any mid-drag write touching wall children) zeroed the refcount and resumed tracking mid-gesture. Fix: the gesture holds a refcounted acquireSceneHistoryPause lease (beginOpeningMoveHistorySession); mid-drag writes track nothing and cooperating systems see the interaction through the depth gate; the drop releases the lease for exactly ONE tracked write. Undo of a completed drag restores the exact pre-drag state in one step.

13 new tests (gate predicate incl. the interposed-hidden-wall and own-hidden-wall cases; history session incl. the raw-pause leak regression). Root suite 3591 pass / 0 fail, turbo test 13/13, biome clean.

Known follow-up (out of scope): ~35 other files use raw temporal.pause() with the same latent resume-leak pattern, including the PLACE tools' repeat-place flow.

🤖 Generated with Claude Code

---

Note

Medium Risk
Touches scene undo/history pause ownership and wall-hit routing during opening moves, so a lease or gate mistake can corrupt undo stacks or re-parent openings. Changes are scoped to the door/window MOVE tools with targeted tests.

Overview
Fixes two X-ray MOVE bugs for doors and windows: hidden walls no longer steal the drag, and a completed move is a single undo step.

While moving an existing opening, hidden-wall events are ignored unless they come from the grab wall or current host. Ignored events do not stop propagation, so the ray falls through to the own wall. Visible walls still accept cross-wall re-parenting; PLACE/duplicate keep all-walls X-ray behavior.

Move tools now hold a refcounted acquireSceneHistoryPause lease via beginOpeningMoveHistorySession instead of a raw temporal.pause(). Mid-drag writes stay untracked; commitStep records exactly one drop. Cancel leaves no undo entry. Tests cover the wall-gate truth table and the history-lease leak.

^{Reviewed by Cursor Bugbot for commit f028cc2. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit f028cc2. Configure here.}

[cursor]

Leave from ignored walls resets drag

Medium Severity

The new hidden-wall gate skips wall:enter, wall:move, and wall:click from interposed hidden walls, but onWallLeave still runs for those same walls. Because ignored events do not call stopPropagation, those walls still enter R3F hover and later emit wall:leave while the opening is riding its own wall. That handler clears dragAnchor and lastTarget, so the next own-wall move reseeds the grab offset and the door or window snaps back toward its original along-wall position—the X-ray MOVE path this change is meant to fix.

Additional Locations (1)

• packages/nodes/src/window/move-tool.tsx#L663-L678

 

^{Reviewed by Cursor Bugbot for commit f028cc2. Configure here.}