Skip to content

feat: Use JsonPropertyName in $select query path generation #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterH-CPH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Use JsonPropertyName in $select query path generation #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PanoramicData.OData.Client.Test/UnitTests/QueryBuilderQueryOptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public void Select_WithExpression_GeneratesCorrectUrl()
.BuildUrl();

url.Should().Contain("$select=");
url.Should().Contain("Id");
url.Should().Contain("ID");
url.Should().Contain("Name");
}

Expand Down
3 changes: 2 additions & 1 deletion PanoramicData.OData.Client/ODataQueryBuilder.ExpressionParsing.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ private static string GetMemberPath(MemberExpression member)

while (current is MemberExpression memberExpr)
{
pathStack.Push(memberExpr.Member.Name);
var jsonPropertyNameAttribute = memberExpr.Member.GetCustomAttribute<JsonPropertyNameAttribute>();

@codacy-production codacy-production Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Suggestion: Calling GetCustomAttribute repeatedly during expression parsing adds reflection overhead to every query segment. Since property name mappings are static for the lifetime of the application, consider caching these results in a ConcurrentDictionary<MemberInfo, string> to improve performance in high-throughput scenarios.

Try running the following prompt in your coding agent:

In ODataQueryBuilder.ExpressionParsing.cs, introduce a static ConcurrentDictionary to cache the mapping from MemberInfo to the property name resolved from JsonPropertyNameAttribute within the GetMemberPath method.

pathStack.Push(jsonPropertyNameAttribute?.Name ?? memberExpr.Member.Name);
current = memberExpr.Expression;
}

Expand Down