[Draft] Literal Include#61
Draft
ax3l wants to merge 3 commits into
Draft
Conversation
Quick draft w/ Cursor on include support.
EZoni
reviewed
Jun 8, 2026
| facility_included_file.write_text(facility_included_content) | ||
| facility_nested_file.write_text(facility_nested_content) | ||
|
|
||
| data = pals.Lattice.from_file(main_file) |
Member
There was a problem hiding this comment.
What was the intention here? Why does this go through Lattice.from_file as opposed to going through functions.load_file_to_dict as below (which would work here too - tested locally)? Could you comment on whether you wanted to expand the Lattice.from_file function but haven't gotten to implement the feature in the PR yet? I think I'm missing some context, inteded use case, and current PR progress, to start working on completing this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick draft w/ Cursor on include support.