Separate pull-request reviews from comments - #721
Merged
sudomaggie merged 1 commit intoAug 6, 2026
Merged
Conversation
Harry19081
marked this pull request as ready for review
August 6, 2026 13:00
sudomaggie
merged commit Aug 6, 2026
8a46173
into
dev/rich-text-shared-toolbar-controls
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pull-request level actions and review decisions compete with the scrolling conversation and comment input. Approve and Request changes submit directly from the conversation draft, which conflates review bodies with ordinary comments and does not make the reviewed head commit explicit.
Solution
Dock the PR composer below the scrolling timeline, place PR-level merge/reviewer/state actions directly above its input, and move review submission into a dedicated modal with Comment, Approve, and Request changes decisions. Anchor submitted reviews to the displayed head SHA, localize the complete PR action vocabulary in every supported locale, and use compact upward-opening toolbars for comment and review-thread editors.
Potential risks
The docked composer reserves at least 240 px, so very short panels have less visible conversation space. A review falls back to GitHub's current head when the displayed SHA is unavailable; when present, the explicit SHA can cause GitHub to reject a review if the PR advanced, which protects against reviewing unseen code. This PR is stacked on PR #719 and expects PR #714's right-aligned dropdown default for the action menus. Manual responsive, keyboard, and modal evidence is pending, so this PR remains a draft.
Performance guard
Verdict: pass. The composer adds one element measurement observer while the conversation is mounted and releases it through the existing hook cleanup. It adds no timer, poll, network request, subscription, or cache; hidden/idle behavior is unchanged, repeated mounts do not retain listeners, and multi-instance cost is bounded to one observer per mounted PR conversation.
Audit
The configured
frontend-ui-auditskill file was unavailable at both documented locations. A direct pass confirmed reuse of Modal, Radio, Textarea, Button, Dropdown, ComposerShell, and RichMarkdownEditor, with native labels/fieldset semantics and localized actions rather than one-off controls.Verification
pnpm typecheck— passed.jq emptyfor all 13 changed locale files — passed.git diff --cached --check— passed before commit.