Skip to content

chore(deps): Bump react and @types/react - #170

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/multi-b0dfc253ff
Closed

chore(deps): Bump react and @types/react#170
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/multi-b0dfc253ff

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 8, 2026

Copy link
Copy Markdown
Contributor

Bumps react and @types/react. These dependencies needed to be updated together.
Updates react from 18.3.1 to 19.2.8

Release notes

Sourced from react's releases.

19.2.8 (July 21st, 2026)

React Server Components

19.2.7 (June 1st, 2026)

React Server Components

19.2.6 (May 6th, 2026)

React Server Components

19.2.5 (April 8th, 2026)

React Server Components

19.2.4 (January 26th, 2026)

React Server Components

19.2.3 (December 11th, 2025)

React Server Components

19.2.2 (December 11th, 2025)

React Server Components

19.2.1 (December 3rd, 2025)

React Server Components

19.2.0 (Oct 1, 2025)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.2 release post for more information.

New React Features

... (truncated)

Changelog

Sourced from react's changelog.

19.2.7 (June 1, 2026)

React Server Components

19.2.6 (May 6, 2026)

React Server Components

19.2.5 (March 18, 2026)

React Server Components

19.2.4 (Jan 26, 2026)

React Server Components

19.2.3 (Dec 11, 2025)

React Server Components

19.2.2 (Dec 11, 2025)

React Server Components

19.2.1 (Dec 3, 2025)

React Server Components

19.2.0 (October 1st, 2025)

Below is a list of all new features, APIs, and bug fixes.

Read the React 19.2 release post for more information.

New React Features

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.


Updates @types/react from 18.3.29 to 19.2.17

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jun 8, 2026
@oratis

oratis commented Aug 2, 2026

Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps [react](https://github.com/react/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together.

Updates `react` from 18.3.1 to 19.2.8
- [Release notes](https://github.com/react/react/releases)
- [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/react/react/commits/v19.2.8/packages/react)

Updates `@types/react` from 18.3.29 to 19.2.17
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react)

---
updated-dependencies:
- dependency-name: "@types/react"
  dependency-version: 19.2.17
  dependency-type: direct:development
  update-type: version-update:semver-major
- dependency-name: react
  dependency-version: 19.2.7
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@oratis

oratis commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Review: superseded by #211 — cannot merge as-is

Two independent blockers, both real:

1. This is half of a coupled pair. #170 bumps react + @types/react; #171 bumps react-dom + @types/react-dom. Merging either alone leaves the tree at react@19 + react-dom@18 (or the reverse), which is unsupported. That's why this has been red since June — it isn't flakiness.

2. Neither PR carries the code change React 19 requires. React 19's @types/react removed the global JSX namespace (it now lives under React.JSX). This repo has 38 JSX.Element annotations across 25 desktop files that resolve against the old global; every one fails with TS2503: Cannot find namespace 'JSX' under the new types. Confirmed in this PR's own CI log.

#211 does all three parts together — both halves of the pair plus the JSX import fix — and verifies with a forced rebuild (tsc -b --force), plus the desktop Playwright journey since React 19 changes runtime behaviour and not only types.

Worth recording why the forced rebuild matters: my first local pnpm typecheck on this bump passed, because tsc -b is incremental and reused .tsbuildinfo, silently skipping the desktop project — the exact project that was broken. CI was right and the local run was wrong.

Closing in favour of #211. Full credit to Dependabot for surfacing the bump.

@oratis

oratis commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Superseded by #211 (React 18 → 19 with both halves of the pair + the JSX namespace fix).

@oratis oratis closed this Aug 2, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/multi-b0dfc253ff branch August 2, 2026 07:09
oratis added a commit that referenced this pull request Aug 2, 2026
…fix (#211)

Supersedes #170 and #171, which each bump only half the pair and cannot
merge independently — react@19 with react-dom@18 (or vice versa) is a
broken tree.

React 19's @types/react removes the global `JSX` namespace; it now lives
under `React.JSX` and is re-exported as a named type from 'react'. 38
`JSX.Element` references across 25 desktop files were resolving against
the old global and fail with TS2503 under the new types. Each file now
imports the type explicitly, merged into its existing 'react' import
where one exists so no duplicate-import lint warning is introduced
(root lint is --max-warnings=0 as of #210).

Verified with a forced rebuild (`tsc -b --force`) rather than an
incremental one — `tsc -b` reuses .tsbuildinfo and silently skips the
desktop project, which masks exactly this class of failure.

- tsc -b --force, lint (--max-warnings=0), format:check: clean
- 1033 tests across 8 packages: pass
- pnpm build: pass
- desktop Playwright protocol journey (4 tests): pass

Co-authored-by: t <t@t>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant