Skip to content

[ci] CI failure analysis: --allow-escape-sequences - #738

Merged
nemesifier merged 1 commit into
masterfrom
fix-ci-failure-log-escape-sequences
Aug 23, 2026
Merged

[ci] CI failure analysis: --allow-escape-sequences#738
nemesifier merged 1 commit into
masterfrom
fix-ci-failure-log-escape-sequences

Conversation

@nemesifier

Copy link
Copy Markdown
Member

Checklist

Reference to Existing Issue

N/A

Description of Changes

Allows the GitHub CLI job-log fetch to output terminal escape sequences, preserving GitHub Actions error markers for the existing failure extractor. Adds regression coverage for the required CLI option.

Screenshot

N/A

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2d15230e-28e4-408e-ab1b-c00544068b0b

📥 Commits

Reviewing files that changed from the base of the PR and between 57059cc and a95335d.

📒 Files selected for processing (2)
  • .github/actions/bot-ci-failure/test_analyze_failure.py
  • .github/workflows/reusable-bot-ci-failure.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (15)
  • GitHub Check: Python==3.12 | django~=4.2.0
  • GitHub Check: Python==3.10 | django~=5.0.0
  • GitHub Check: Python==3.12 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=5.1.0
  • GitHub Check: Python==3.13 | django~=5.2.0
  • GitHub Check: Python==3.13 | django~=5.1.0
  • GitHub Check: Python==3.11 | django~=5.2.0
  • GitHub Check: Python==3.11 | django~=4.2.0
  • GitHub Check: Python==3.10 | django~=5.1.0
  • GitHub Check: Python==3.12 | django~=5.2.0
  • GitHub Check: Python==3.12 | django~=5.0.0
  • GitHub Check: Python==3.10 | django~=4.2.0
  • GitHub Check: Python==3.11 | django~=5.0.0
  • GitHub Check: Python==3.10 | django~=5.2.0
  • GitHub Check: Kilo Code Review
🧰 Additional context used
📓 Path-based instructions (1)
.github/**

⚙️ CodeRabbit configuration file

.github/**: Do not complain about dependencies installed from controlled mutable
OpenWISP branches. Branch protection restricts changes to those
branches.

Files:

  • .github/workflows/reusable-bot-ci-failure.yml
  • .github/actions/bot-ci-failure/test_analyze_failure.py
🔇 Additional comments (2)
.github/actions/bot-ci-failure/test_analyze_failure.py (1)

5-5: LGTM!

Also applies to: 25-37

.github/workflows/reusable-bot-ci-failure.yml (1)

98-98: 🩺 Stability & Availability

No version change is required.

ubuntu-latest provides gh 2.97.0, which supports --allow-escape-sequences.

			> Likely an incorrect or invalid review comment.

📝 Walkthrough

Walkthrough

The reusable workflow now passes --allow-escape-sequences to gh api when it fetches failed job logs. Existing error handling and log output remain unchanged. A test resolves the workflow file and verifies that the log-fetch command includes the option.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a9533

This change adjusts CI failure-log handling to preserve escape sequences and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Ui Changes, Regression Test, Docs ✅ Passed The diff is CI-only and adds a regression test for --allow-escape-sequences; it introduces no application UI or new documented user-facing feature.
Title check ✅ Passed The title uses the required [ci] prefix and clearly describes the escape-sequence change in the workflow.
Description check ✅ Passed The description includes all required sections and explains the workflow change and regression test; documentation and issue references are marked N/A.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci-failure-log-escape-sequences

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kilo-code-bot

kilo-code-bot Bot commented Aug 23, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • .github/actions/bot-ci-failure/test_analyze_failure.py
  • .github/workflows/reusable-bot-ci-failure.yml

Reviewed by balanced · Input: 55K · Output: 10.7K · Cached: 284K

@nemesifier nemesifier changed the title Allow CI failure log escape sequences [ci] Allowed CI failure log escape sequences Aug 23, 2026
@nemesifier nemesifier self-assigned this Aug 23, 2026
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage is 97.611%fix-ci-failure-log-escape-sequences into master. No base build found for master.

@nemesifier nemesifier added enhancement github_actions Pull requests that update GitHub Actions code labels Aug 23, 2026
@nemesifier nemesifier changed the title [ci] Allowed CI failure log escape sequences [ci] CI failure analysis: --allow-escape-sequences Aug 23, 2026
@nemesifier
nemesifier merged commit 1ff546d into master Aug 23, 2026
38 of 39 checks passed
@nemesifier
nemesifier deleted the fix-ci-failure-log-escape-sequences branch August 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants