Skip to content

chore(ci): cover dynamic value mapping obligations - #3924

Merged
jakedoublev merged 1 commit into
mainfrom
test/dynamic-value-obligation-bdd
Aug 27, 2026
Merged

chore(ci): cover dynamic value mapping obligations#3924
jakedoublev merged 1 commit into
mainfrom
test/dynamic-value-obligation-bdd

Conversation

@jakedoublev

@jakedoublev jakedoublev commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Adds BDD coverage for obligation triggers on existing attribute values entitled through a dynamic value mapping, including fulfillable, unfulfilled, and unentitled outcomes.

Summary by CodeRabbit

  • Tests
    • Added coverage for obligations applied to existing attribute values through dynamic value mappings.
    • Verified access behavior when obligations are fulfilled, unfulfilled, or when entitlement is unavailable.

Signed-off-by: jakedoublev <jake.vanvorhis@virtru.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 12ee2666-0834-4ebd-9a71-2cb9383d7826

📥 Commits

Reviewing files that changed from the base of the PR and between 0514145 and 6e8a3dd.

📒 Files selected for processing (1)
  • tests-bdd/features/dynamic-value-mapping-obligations.feature

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The BDD feature adds dynamic value mapping data and tests obligation handling for entitled users and users without entitlement.

Changes

Dynamic Value Mapping Obligations

Layer / File(s) Summary
Dynamic entitlement obligation scenarios
tests-bdd/features/dynamic-value-mapping-obligations.feature
The feature creates users, namespace metadata, an obligation trigger, a dynamic value mapping, and subject entities. Scenarios cover fulfilled and unfulfilled obligations and omit the obligation for non-entitled access.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 6e8a3

This change only adds localized BDD coverage for dynamic value mapping obligation outcomes, with no production behavior changes or actionable merge-blocking risk remaining.

Suggested reviewers: alkalescent

Poem

A rabbit mapped values in rows neat and bright

An obligation waited, prepared for the night
Fulfilled ones opened the gate
Unfulfilled ones returned their state
No entitlement? No obligation in sight

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding CI test coverage for obligations in dynamic value mappings. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/dynamic-value-obligation-bdd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 253.521353ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 127.750917ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 442.425106ms
Throughput 226.03 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 42.510823435s
Average Latency 424.247174ms
Throughput 117.62 requests/second

@jakedoublev jakedoublev changed the title test(authz): cover dynamic value mapping obligations chore(ci): cover dynamic value mapping obligations Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • examples
  • otdfctl
  • sdk
  • service
  • lib/ocrypto
  • lib/fixtures
  • tests-bdd

See the workflow run for details.

@jakedoublev
jakedoublev marked this pull request as ready for review August 27, 2026 18:19
@jakedoublev
jakedoublev requested a review from a team as a code owner August 27, 2026 18:19
@jakedoublev
jakedoublev enabled auto-merge August 27, 2026 18:20
@jakedoublev
jakedoublev added this pull request to the merge queue Aug 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 27, 2026
@jakedoublev
jakedoublev added this pull request to the merge queue Aug 27, 2026
Merged via the queue into main with commit 012ad2d Aug 27, 2026
112 of 120 checks passed
@jakedoublev
jakedoublev deleted the test/dynamic-value-obligation-bdd branch August 27, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants