Add optional e2e-vmaas-full-setup-helm presubmit and fix VALUES_FILE path

[omer-vishlitzky]

Summary

Two changes:

1. Fix VALUES_FILE default in osac-project-installer step ref — the osac-installer repo restructured values files from values/<env>.yaml to values/<env>/values.yaml (PR Add Helm-based VMaaS CI deployment path osac-project/osac-installer#296). Supersedes OSAC-1657: fix e2e-vmaas-full-setup-helm values file path #80834.

2. Add optional full-setup-helm presubmit to osac-installer — manually triggered via /test e2e-vmaas-full-setup-helm, optional: true, always_run: false. Uses the same workflow and env as the periodic in osac-test-infra, with OSAC_INSTALLER_IMAGE set to the PR's built image.

Summary by CodeRabbit

This PR updates CI infrastructure in the openshift/release repo for the osac-installer project in two practical ways:

1. Fixes the VALUES_FILE default path used by the osac-project-installer step reference (ci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml). It changes the default from values/vmaas-ci.yaml to values/vmaas-ci/values.yaml to match the osac-installer repo’s updated values layout.

2. Adds an optional Helm “full setup” presubmit to the osac-installer job config (ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml). It introduces the e2e-vmaas-full-setup-helm test as optional: true and always_run: false, so it won’t run automatically. Developers can manually trigger it with /test e2e-vmaas-full-setup-helm. The test uses the same workflow/environment shape as the corresponding periodic job, including DEPLOY_MODE: helm, and sets OSAC_INSTALLER_IMAGE to the image built from the PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7f91ef40-ee0e-473e-b716-0d9b1ccfd7f5

📥 Commits

Reviewing files that changed from the base of the PR and between 468f111 and 5214708.

📒 Files selected for processing (1)

• ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml

---

Walkthrough

Adds a new optional CI test entry e2e-vmaas-full-setup-helm targeting cluster_profile: packet-osac with helm deploy mode, OpenShift 4.20, and the osac-project-ofcir-baremetal workflow. Also updates the VALUES_FILE default in the installer step registry from values/vmaas-ci.yaml to values/vmaas-ci/values.yaml.

Changes

Helm E2E CI Configuration

Layer / File(s)	Summary
Helm e2e test entry and VALUES_FILE path alignment ci-operator/step-registry/osac-project/installer/osac-project-installer-ref.yaml, ci-operator/config/osac-project/osac-installer/osac-project-osac-installer-main.yaml	Updates the installer step's VALUES_FILE default from values/vmaas-ci.yaml to values/vmaas-ci/values.yaml, then adds the e2e-vmaas-full-setup-helm test with helm deployment mode, OpenShift 4.20, assisted configuration for OLM operators and resource sizing, and workflow routing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

• openshift/release#80807: Directly related — introduces the helm migration that standardizes VALUES_FILE pointing to values/vmaas-ci/values.yaml, which this PR aligns with in both the new test entry and the installer step default path fix.

Suggested reviewers

• adriengentil
• eranco74
• danmanor

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes both main changes: adding an optional e2e-vmaas-full-setup-helm presubmit and fixing the VALUES_FILE path, matching the actual changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Custom check for Ginkgo test names is not applicable. The PR modifies CI YAML configuration files only, not Ginkgo test code. CI job identifiers like "e2e-vmaas-full-setup-helm" are distinct from G...
Test Structure And Quality	✅ Passed	This PR modifies only CI/CD configuration YAML files (osac-project-osac-installer-main.yaml and osac-project-installer-ref.yaml), not Ginkgo test code. The check is not applicable to this PR.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The changes are CI/CD configuration updates only (YAML files), so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only modifies CI/CD configuration files (YAML), not Ginkgo test code. The openshift/release repository contains job definitions, not test implementations. No new e2e tests are added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains only CI/CD configuration changes (job definitions and step registry defaults), not deployment manifests, operator code, or controllers. No topology-aware or topology-unaware scheduling...
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML CI configuration files (not OTE binary code). Custom check for stdout contract in process-level code is not applicable to configuration-only changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies only CI configuration files (YAML), not Ginkgo e2e test code. No new tests are added, so IPv6/disconnected network compatibility check does not apply.
No-Weak-Crypto	✅ Passed	PR contains only CI/CD configuration changes (YAML files) with no cryptographic code, weak crypto algorithms, custom crypto implementations, or secret comparisons detected.
Container-Privileges	✅ Passed	No privileged container configurations found. PR modifies CI config files updating a path default and adding a test workflow; no container privilege settings (privileged, hostPID/Network/IPC, SYS_A...
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive data (passwords, tokens, API keys, PII, etc.) are logged in the changes; environment variables and configuration are all non-sensitive, and existing pull-secret redaction patterns are...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: omer-vishlitzky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/osac-project/osac-installer/OWNERS [omer-vishlitzky]
• ci-operator/jobs/osac-project/osac-installer/OWNERS [omer-vishlitzky]
• ci-operator/step-registry/osac-project/installer/OWNERS [omer-vishlitzky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[omer-vishlitzky]

/pj-rehearse ack

[openshift-merge-bot]

@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@omer-vishlitzky: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-osac-project-osac-installer-main-e2e-vmaas-full-setup-helm	osac-project/osac-installer	presubmit	Presubmit changed
periodic-ci-osac-project-osac-test-infra-main-e2e-vmaas-full-setup-helm	N/A	periodic	Registry content changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@omer-vishlitzky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[omer-vishlitzky]

/pj-rehearse ack

[openshift-merge-bot]

@omer-vishlitzky: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.