Skip to content

Switch RMO operator e2e to cluster pool workflow#80872

Open
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60066/rmo-pool-workflow
Open

Switch RMO operator e2e to cluster pool workflow#80872
dustman9000 wants to merge 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60066/rmo-pool-workflow

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Switch both presubmit (rosa-sts-e2e) and periodic (rosa-sts-e2e-promotion-stage) to use rosa-pool-e2e-workflow instead of rosa-operator-e2e-workflow. Pool clusters are pre-provisioned, reducing job time from ~90 min (ephemeral provision) to ~15 min (pool checkout).

This also fixes the SAPM 3h pipeline timeout issue where the gangway-bridge Job was timing out waiting for the Prow job to complete.

Jira: https://redhat.atlassian.net/browse/ROSAENG-60066

Summary by CodeRabbit

This PR updates the Route Monitor Operator's ROSA STS E2E test configuration to leverage pre-provisioned pool clusters instead of ephemeral cluster provisioning. Specifically, both the rosa-sts-e2e presubmit job and the rosa-sts-e2e-promotion-stage periodic job have their workflow migrated from rosa-operator-e2e-workflow to rosa-pool-e2e-workflow.

Impact:

  • Execution time: Reduces job duration from approximately 90 minutes (with cluster provisioning/deprovisioning) to approximately 15 minutes (with cluster checkout/checkin from standby pool)
  • Pipeline reliability: Addresses a SAPM 3-hour timeout issue where the gangway-bridge Job was timing out while waiting for the Prow job to complete

Technical change: The rosa-pool-e2e-workflow replaces the full cluster provisioning steps (rosa-aws-sts-provision chain) and deprovisioning steps (rosa-aws-sts-deprovision chain) with simple pool checkout (rosa-pool-checkout) and checkin (rosa-pool-checkin) references. The core operator installation and e2e testing steps remain unchanged.

Scope: This configuration change applies to the Route Monitor Operator CI in the openshift/release repository and does not affect any other job properties, environment variables, or test logic.

Replace rosa-operator-e2e-workflow with rosa-pool-e2e-workflow for
both presubmit and promotion-stage periodic. Pool clusters are
pre-provisioned, reducing job time from ~90 min to ~15 min.
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7e34c931-a01a-4340-919a-8d17b1256ce9

📥 Commits

Reviewing files that changed from the base of the PR and between 34853b9 and 2f78846.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml

Walkthrough

In the CI operator config for openshift/route-monitor-operator (master branch), the workflow field in two ROSA STS e2e job definitions (rosa-sts-e2e and rosa-sts-e2e-promotion-stage) is changed from rosa-operator-e2e-workflow to rosa-pool-e2e-workflow. No other settings are modified.

Changes

ROSA STS E2E Workflow Update

Layer / File(s) Summary
ROSA STS e2e workflow selector
ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml
The workflow value for rosa-sts-e2e (line 86) and rosa-sts-e2e-promotion-stage (line 107) is changed from rosa-operator-e2e-workflow to rosa-pool-e2e-workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#80859: Updates the rosa-pool-e2e-workflow checkout step to support POOL_ENV and environment-aware OCM login — directly related to the pool-based workflow being adopted here.

Suggested reviewers

  • ravitri
  • joshbranham
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: switching RMO operator e2e jobs to use the cluster pool workflow instead of the operator workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI operator configuration (YAML), not Ginkgo test code. No test definitions (It(), Describe(), etc.) are changed. Check is not applicable.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code changes; it only modifies CI/Prow configuration YAML files to update workflow references. The custom check for test code quality is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR. The changes only modify CI workflow configuration for existing tests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added; PR only modifies CI workflow configuration (rosa-operator-e2e-workflow → rosa-pool-e2e-workflow). SNO compatibility check not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a Prow CI configuration file to switch E2E test workflows, not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed PR contains only Prow CI configuration changes (YAML files) with no Go source code modifications. The OTE Binary Stdout Contract check applies only to process-level code changes, not CI configurati...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any new Ginkgo e2e tests. It only modifies CI/CD configuration files (YAML) to switch workflows. The check for IPv6 and disconnected network compatibility is not applicable.
No-Weak-Crypto ✅ Passed The PR only modifies Prow CI configuration, updating workflow references from rosa-operator-e2e-workflow to rosa-pool-e2e-workflow. No cryptographic code, weak algorithms, or secret comparisons are...
Container-Privileges ✅ Passed PR only changes workflow references and contains no container privilege escalation settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN capability, or allowPrivilegeEscalation) in the con...
No-Sensitive-Data-In-Logs ✅ Passed The PR changes workflow references without introducing any logging that exposes sensitive data such as passwords, tokens, API keys, or PII. Credential usage is only logged descriptively, never with...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from anispate and tnierman June 22, 2026 19:58
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-route-monitor-operator-master-rosa-sts-e2e openshift/route-monitor-operator presubmit Ci-operator config changed
periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage 2f78846 link unknown /pj-rehearse periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant