Skip to content

OCPBUGS-86448: Disable monitor on disruptive and longduration MCO suites#80871

Open
djoshy wants to merge 1 commit into
openshift:mainfrom
djoshy:remove-monitor-mco-disruptive
Open

OCPBUGS-86448: Disable monitor on disruptive and longduration MCO suites#80871
djoshy wants to merge 1 commit into
openshift:mainfrom
djoshy:remove-monitor-mco-disruptive

Conversation

@djoshy

@djoshy djoshy commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Disables the audit log analyzer monitor test on the disruptive and longduration MCO suites.

Summary by CodeRabbit

This pull request updates the CI configuration for the OpenShift Machine Configuration Operator (MCO) across multiple release branches (4.19 through 5.1) and the main branch. The changes disable the audit-log-analyzer monitoring probe on disruptive and long-duration test suites by adding the TEST_ARGS: --disable-monitor=audit-log-analyzer environment variable to the relevant E2E test job definitions in Prow CI configuration files.

Scope of changes:

  • Affected component: Machine Configuration Operator CI test jobs
  • Test suites modified: Disruptive tests (AWS, Azure, GCP, vSphere, and bare metal variants) and long-duration tests (vSphere and AWS FIPS proxy variants)
  • Configuration files: 19 CI configuration files across main and release branches (4.19-5.1), including both standard and periodics job definitions, with some branches also having ARM64 periodic variants

The changes are consistently applied across all disruptive MCO test job variants and selected long-duration jobs, ensuring the audit-log-analyzer is disabled across the entire test matrix to address the issue referenced in OCPBUGS-86448.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-86448, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Disables the audit log analyzer monitor test on the disruptive and longduration MCO suites.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2370e912-5a85-4428-9b19-4c8b391af1d0

📥 Commits

Reviewing files that changed from the base of the PR and between c89a45f and e6728f3.

📒 Files selected for processing (17)
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.19.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.19__periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.20.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.20__periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.21.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.21__periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__arm64-periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.22__periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__arm64-periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-4.23__periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__arm64-periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.0__periodics.yaml
  • ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-release-5.1.yaml

Walkthrough

Across 17 CI config YAML files spanning OpenShift MCO branches (main, 4.19–4.23, 5.0–5.1), TEST_ARGS: --disable-monitor=audit-log-analyzer is added to the env block of every disruptive, techpreview, and longduration E2E test job. No other job settings are modified.

Changes

MCO disruptive E2E job TEST_ARGS update

Layer / File(s) Summary
Release and main branch per-PR job configs
ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-main.yaml, ...release-4.19.yaml, ...release-4.20.yaml, ...release-4.21.yaml, ...release-4.22.yaml, ...release-4.23.yaml, ...release-5.0.yaml, ...release-5.1.yaml
Adds TEST_ARGS: --disable-monitor=audit-log-analyzer to the env block of e2e-aws-mco-disruptive and e2e-gcp-mco-disruptive jobs in all non-periodic release configs.
Periodic job configs across all release branches
...release-4.19__periodics.yaml, ...release-4.20__periodics.yaml, ...release-4.21__periodics.yaml, ...release-4.22__periodics.yaml, ...release-4.22__arm64-periodics.yaml, ...release-4.23__periodics.yaml, ...release-4.23__arm64-periodics.yaml, ...release-5.0__periodics.yaml, ...release-5.0__arm64-periodics.yaml
Adds the same TEST_ARGS env entry to all periodic disruptive, techpreview, and longduration MCO E2E jobs across AWS, Azure, GCP, vSphere, metal IPI OVN (IPv4/IPv6/dualstack), arm64, single-node, and FIPS-proxy variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, approved, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: disabling a monitor on MCO test suites, with reference to the associated Jira issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR does not add or modify any Ginkgo test definitions; it only updates CI configuration YAML files to add test arguments. Check is not applicable.
Test Structure And Quality ✅ Passed PR modifies only CI configuration YAML files to disable audit-log-analyzer monitor in tests; contains no Ginkgo test code, so check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are added in this PR—only CI configuration YAML files are modified to add TEST_ARGS flags to existing test jobs. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies CI configuration files only, not test code. No new Ginkgo e2e tests (It(), Describe(), Context(), etc.) are being added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI configuration files to disable a monitor on test jobs. No deployment manifests, operator code, or controllers are changed, so topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed This PR only modifies YAML CI configuration files, not Go source code. The OTE Binary Stdout Contract check applies only to executable code that could write to stdout, making it inapplicable to con...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI operator config files to disable audit-log-analyzer monitor on existing tests; no new Ginkgo e2e test code is added, so the IPv6/disconnected network compatibility check does no...
No-Weak-Crypto ✅ Passed PR contains only CI/CD configuration changes (YAML test job definitions), not source code with cryptographic operations. No weak crypto, custom crypto, or secret comparisons present.
Container-Privileges ✅ Passed CI configuration files contain no container privilege settings (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, runAsUser:0). Changes only add TEST_ARGS environment...
No-Sensitive-Data-In-Logs ✅ Passed PR adds only --disable-monitor=audit-log-analyzer flag to CI config files with no hardcoded credentials, API keys, PII, or sensitive data; the change actually disables monitoring to prevent sensi...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@djoshy: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-main-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-main-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-5.0-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-5.0-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-5.1-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-5.1-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.19-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.19-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.20-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.20-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.22-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.22-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.21-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.21-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.23-e2e-aws-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
pull-ci-openshift-machine-config-operator-release-4.23-e2e-gcp-mco-disruptive openshift/machine-config-operator presubmit Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-azure-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-vsphere-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-metal-ipi-ovn-ipv4-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-gcp-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.20-periodics-e2e-vsphere-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-aws-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.19-periodics-e2e-metal-ipi-ovn-ipv6-mco-disruptive N/A periodic Ci-operator config changed
periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive N/A periodic Ci-operator config changed

A total of 55 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants