TMP: Pause kubevirt CSI e2e for OCPBUGS-77929 testing#80869
Conversation
WalkthroughA single Changeshypershift-kubevirt-csi-e2e Workflow Post Phase
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jiezhao16 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-kubevirt-aws-ovn-csi |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/hypershift/kubevirt/csi-e2e/hypershift-kubevirt-csi-e2e-workflow.yaml`:
- Line 31: The wait step reference at line 31 is using default parameter values
(PR_ONLY=false and TIMEOUT=+3 hours) which causes all job runs to block
post-cleanup for extended periods and unnecessarily holds leased infrastructure.
Add parameter overrides to the wait step by setting PR_ONLY to "true" (and
optionally set a shorter TIMEOUT value) to scope this temporary debug path so it
only applies to PR runs and completes faster.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 45a73a88-b9af-4c5b-afd5-0ec5a172eb9d
📒 Files selected for processing (1)
ci-operator/step-registry/hypershift/kubevirt/csi-e2e/hypershift-kubevirt-csi-e2e-workflow.yaml
| test: | ||
| - chain: hypershift-kubevirt-run-csi-e2e | ||
| post: | ||
| - ref: wait |
There was a problem hiding this comment.
Scope the debug wait so it doesn’t stall all job types.
At Line 31, wait uses defaults (PR_ONLY=false, TIMEOUT=+3 hours), so every run can block post-cleanup for hours and hold leased infra longer than needed. Please set PR_ONLY: "true" (and optionally a shorter TIMEOUT) for this temporary debug path.
Suggested change
workflow:
as: hypershift-kubevirt-csi-e2e
@@
steps:
env:
COMPUTE_NODE_TYPE: c5n.metal
CONTROL_PLANE_INSTANCE_TYPE: "m6i.2xlarge"
COMPUTE_NODE_REPLICAS: "1"
ZONES_COUNT: "3"
SKIP_MONITOR_TEST: "true"
+ PR_ONLY: "true"
+ TIMEOUT: "+30 minutes"
@@
post:
- ref: wait🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/hypershift/kubevirt/csi-e2e/hypershift-kubevirt-csi-e2e-workflow.yaml`
at line 31, The wait step reference at line 31 is using default parameter values
(PR_ONLY=false and TIMEOUT=+3 hours) which causes all job runs to block
post-cleanup for extended periods and unnecessarily holds leased infrastructure.
Add parameter overrides to the wait step by setting PR_ONLY to "true" (and
optionally set a shorter TIMEOUT value) to scope this temporary debug path so it
only applies to PR runs and completes faster.
|
@jiezhao16: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse abort |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 participant
Summary
waitstep to thehypershift-kubevirt-csi-e2eworkflow post phase to pause the cluster for OCPBUGS-77929 debuggingTest plan
Summary by CodeRabbit
This PR adds a temporary debugging step to the
hypershift-kubevirt-csi-e2eworkflow in the OpenShift CI infrastructure.Change: A
waitstep has been inserted at the beginning of the workflow'spostphase, before the existing cleanup and teardown chains. This will cause the workflow to pause for up to 3 hours (configurable via theTIMEOUTenvironment variable) after the CSI e2e tests complete.Purpose: This is a temporary measure (indicated by the "TMP" prefix) to facilitate debugging of OCPBUGS-77929. The pause allows developers to investigate cluster state and gather additional diagnostic information using the running cluster before it is torn down.
Affected Component: The change only impacts the CI workflow configuration for the HyperShift KubeVirt CSI e2e test job (
ci-operator/step-registry/hypershift/kubevirt/csi-e2e/hypershift-kubevirt-csi-e2e-workflow.yaml). The actual test logic and cluster setup/teardown remain unchanged.