CNF-25270: Export LCA git coordinates to image-based remote scripts#80864
CNF-25270: Export LCA git coordinates to image-based remote scripts#80864fontivan wants to merge 1 commit into
Conversation
- Wire Prow PR metadata into ib-orchestrate-vm remote scripts so lifecycle-agent presubmits checkout the correct source during LCA deploy. Assisted-by: Cursor/auto AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0 For more information on AI attribution statements, see: https://aiattribution.github.io/
openshift-ci-robot
added
the
jira/valid-reference
|
@fontivan: This pull request references CNF-25270 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Depends on rh-ecosystem-edge/ib-orchestrate-vm#117 being merged first |
openshift-ci
Bot
added
the
do-not-merge/hold
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughTwo CI step shell scripts ( ChangesLCA Git coordinate propagation in CI step scripts
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fontivan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 132 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@fontivan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Assisted-by: Cursor/auto
AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0
For more information on AI attribution statements, see: https://aiattribution.github.io/
Summary by CodeRabbit
This PR adds functionality to propagate Prow PR metadata into image-based remote scripts for OpenShift image-based upgrade testing workflows.
What changed:
The PR modifies two CI step registry scripts that orchestrate image-based upgrades using seed and target VMs:
openshift-image-based-upgrade-seed-create-commands.shopenshift-image-based-upgrade-target-commands.shBoth scripts now detect when they are running in the context of a
openshift-kni/lifecycle-agentrepository PR and extract Git coordinates from Prow environment variables:LCA_GIT_REF: The PR head commit SHA (fromPULL_PULL_SHA)LCA_GIT_PULL: The PR number (fromPULL_NUMBER)LCA_GIT_BRANCH: The target branch (fromPULL_BASE_REF)These Git coordinates are then exported as environment variables into the downstream remote scripts (
create_seed.shandupgrade_from_seed.sh) that execute on remote VMs via SSH. The remoteib-orchestrate-vmscripts receive the lifecycle-agent Git repository URL and can use these coordinates to checkout and test the exact source code being validated in the PR.Impact:
This enables lifecycle-agent presubmit jobs to properly test against the correct PR code during image-based orchestration VM deployment and upgrade testing. For other repositories sharing these CI workflows, the variables default to empty strings and the remote scripts fall back to their default behavior.
Lines changed: +18 in each script (36 total)