Skip to content

SPLAT-2803: Updated vSphere VCF 9 jobs to use VCF 9.1 env#80860

Open
vr4manta wants to merge 1 commit into
openshift:mainfrom
vr4manta:SPLAT-2803
Open

SPLAT-2803: Updated vSphere VCF 9 jobs to use VCF 9.1 env#80860
vr4manta wants to merge 1 commit into
openshift:mainfrom
vr4manta:SPLAT-2803

Conversation

@vr4manta

@vr4manta vr4manta commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

SPLAT-2803

Changes

  • Updated existing vSphere OCP 5.0 vcf jobs to use the VCF 9.1 environment

Notes

Not all jobs were updated. We just selected a few 5.0 periodical release jobs to use it as example for other teams that may need to specifically target the VCF 9.1 vCenters / pools

Summary by CodeRabbit

This PR updates the OpenShift CI configuration to target VCF (vSphere Cloud Foundation) 9.1 infrastructure for a subset of OCP 5.0 integration tests.

Changes Made:
The file ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml was modified to add version-specific targeting for three periodic vSphere test jobs. Each job's POOL_SELECTOR environment variable was updated to explicitly require vsphere-version=9.1:

  • e2e-vsphere-ovn-vcf9: Now targets vsphere-type=vcf9,vsphere-version=9.1 (previously just vsphere-type=vcf9)
  • e2e-vsphere-ovn-upi-vcf9: Now targets vsphere-type=vcf9,vsphere-version=9.1 (previously just vsphere-type=vcf9)
  • e2e-vsphere-ovn-csi-vcf9: Now targets vsphere-type=vcf9,vsanfs=true,vsphere-version=9.1 (previously vsphere-type=vcf9,vsanfs=true)

Practical Impact:
These periodic test jobs will now run against VCF 9.1 infrastructure specifically, rather than any available vcf9 environment. This selective update establishes a pattern for teams that need to explicitly target specific VCF versions in their testing infrastructure.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references SPLAT-2803 which is a valid jira issue.

Details

In response to this:

SPLAT-2803

Changes

  • Updated existing vSphere OCP 5.0 vcf jobs to use the VCF 9.1 environment

Notes

Not all jobs were updated. We just selected a few 5.0 periodical release jobs to use it as example for other teams that may need to specifically target the VCF 9.1 vCenters / pools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Three periodic vSphere "vcf9" CI jobs in openshift-release-main__nightly-5.0.yaml have their POOL_SELECTOR environment variable updated to append ,vsphere-version=9.1, narrowing pool selection to version 9.1 specifically.

Changes

POOL_SELECTOR version pin for vcf9 jobs

Layer / File(s) Summary
POOL_SELECTOR vsphere-version=9.1 added to three vcf9 jobs
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
e2e-vsphere-ovn-vcf9 and e2e-vsphere-ovn-upi-vcf9 change from vsphere-type=vcf9 to vsphere-type=vcf9,vsphere-version=9.1; e2e-vsphere-ovn-csi-vcf9 changes from vsphere-type=vcf9,vsanfs=true to vsphere-type=vcf9,vsanfs=true,vsphere-version=9.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating vSphere VCF 9 jobs to use the VCF 9.1 environment, which directly matches the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Check is not applicable; PR modifies CI/CD job configuration YAML only, not Ginkgo test code with test titles.
Test Structure And Quality ✅ Passed The PR modifies YAML CI operator configuration files (specifically POOL_SELECTOR environment values) and contains no Ginkgo test code. The custom check for test code quality is not applicable to th...
Microshift Test Compatibility ✅ Passed This PR modifies CI configuration (POOL_SELECTOR environment variables) for existing vSphere tests, not adding new Ginkgo test code. The check is designed to flag new Ginkgo tests (It(), Describe()...
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR modifies only CI operator configuration (POOL_SELECTOR environment variables in a .yaml file), not test source code. No new Ginkgo e2e tests were added, so the SNO compatibility check does n...
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI/testing configuration (Prow test job pool selectors), not deployment manifests, operator code, or controllers. The custom check does not apply.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration changes (vSphere job environment variables); no code modifications that could violate OTE binary stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only YAML CI configuration (POOL_SELECTOR values), not test code. No new Ginkgo tests are added, making the IPv6/disconnected network compatibility check inapplicable.
No-Weak-Crypto ✅ Passed PR contains only CI configuration changes updating vSphere pool selectors; no weak cryptography, custom crypto implementations, or secret comparisons are present.
Container-Privileges ✅ Passed PR modifies only CI operator config environment variables (POOL_SELECTOR), not container/K8s manifests; no privileged settings or security context changes present.
No-Sensitive-Data-In-Logs ✅ Passed PR only modifies POOL_SELECTOR environment variables with infrastructure selection criteria (vsphere-type, vsphere-version, vsanfs), containing no passwords, tokens, API keys, PII, or sensitive data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from neisw and petr-muller June 22, 2026 17:07
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-csi-vcf9 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-upi-vcf9 N/A periodic Ci-operator config changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-vcf9 N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vr4manta

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-vcf9

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants