Skip to content

HIVE-2881: removing job as duplicate#80858

Open
miyadav wants to merge 1 commit into
openshift:mainfrom
miyadav:removeprivatejobsdrosatest
Open

HIVE-2881: removing job as duplicate#80858
miyadav wants to merge 1 commit into
openshift:mainfrom
miyadav:removeprivatejobsdrosatest

Conversation

@miyadav

@miyadav miyadav commented Jun 22, 2026

Copy link
Copy Markdown
Member

Since PR merged we can remove the job

@2uasimojo PTAL when time permits.

Summary by CodeRabbit

This PR adds a new periodic CI configuration file for the OpenShift Hive repository's master branch. The openshift-hive-master__periodic.yaml file defines a suite of automated test jobs that run on regular schedules:

Key Jobs Added:

  • Weekly e2e tests across multiple cloud providers (AWS, GCP, Azure, vSphere, OpenStack)
  • AWS cluster pool testing
  • A new e2e-ote-sd-rosa job that runs OpenShift Tests Extension (OTE) e2e tests for ROSA deployments on AWS, scheduled to run weekly

Infrastructure Impact:
The new configuration affects the OpenShift CI infrastructure by establishing periodic test coverage for Hive's core functionality across different cloud environments. The e2e-ote-sd-rosa job specifically deploys Hive to an AWS QE cluster and executes the OTE test suite, with intelligent failure categorization (blocking vs. informing) to control job status and timeout settings of 7.5 hours for test execution and 8 hours overall.

The addition relates to PR #79862's consolidation of duplicate job definitions within the Hive CI pipeline.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@miyadav: This pull request references HIVE-2881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Since PR merged we can remove the job

@2uasimojo PTAL when time permits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dc0670c2-83dc-49fd-ad30-7c3eacc64794

📥 Commits

Reviewing files that changed from the base of the PR and between 18915e1 and f7023d5.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/hive/openshift-hive-master-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/hive/openshift-hive-master__periodic.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/hive/openshift-hive-master__periodic.yaml

Walkthrough

The periodic Hive CI config removes the aws-ipi-f7-longduration-hive-sd-rosa job and adds a new e2e-ote-sd-rosa job. The new job deploys Hive, runs an OTE test suite via openshift-tests-extension run-suite, converts JSON results to JUnit XML using jq, and fails only on blocking failures.

Changes

e2e-ote-sd-rosa Periodic Job

Layer / File(s) Summary
Hive deploy step and OTE test execution with JUnit gating
ci-operator/config/openshift/hive/openshift-hive-master__periodic.yaml
Removes the aws-ipi-f7-longduration-hive-sd-rosa job and adds e2e-ote-sd-rosa with aws-qe cluster profile. The new job runs IMG=$HIVE_IMAGE make deploy to install Hive, then executes openshift-tests-extension run-suite, parses JSON results with jq to compute pass/blocking/informing counts, regenerates junit_results.xml, and exits non-zero only when blocking failures are detected. AWS credentials and pull secret are mounted; job timeout is 8h, test timeout is 7h30m.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • openshift/release#79862: Directly overlaps — adds the same e2e-ote-sd-rosa job definition with the same Hive deploy step, openshift-tests-extension run-suite invocation, and JSON→JUnit blocking/informing failure gating in the same file.

Suggested reviewers

  • dlom
  • suhanime
🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning This PR modifies CI configuration YAML files (openshift/hive periodic CI job config), not Ginkgo test code. The custom check is not applicable to this PR. This check requires review of Ginkgo test code (.go test files with It blocks). The PR contains only CI configuration changes, not test implementation code.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing a duplicate job following PR #79862. It is specific, clear, and directly relates to the changeset which removes the aws-ipi-f7-longduration-hive-sd-rosa job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests. All 11 test files are standard Go unit tests using testing.T, making this check not applicable.
Microshift Test Compatibility ✅ Passed This PR modifies a CI configuration YAML file, not test code. No new Ginkgo e2e tests (It(), Describe(), etc.) are added, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI configuration YAML files and removes a duplicate job; it does not add any new Ginkgo e2e tests. Check is not applicable to non-test code changes.
Topology-Aware Scheduling Compatibility ✅ Passed PR removes a duplicate CI job from a configuration file. CI config files do not contain Kubernetes pod scheduling constraints. No topology-incompatible scheduling constructs (affinity, PDB, nodeSel...
Ote Binary Stdout Contract ✅ Passed PR contains only CI configuration YAML changes, no executable code. OTE Binary Stdout Contract check applies to Go/TypeScript/JavaScript code, not configuration files, making it inapplicable to thi...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR adds CI configuration files (YAML), not new Ginkgo e2e tests. The custom check only applies when new Ginkgo e2e test code is added; this PR contains no such code.
No-Weak-Crypto ✅ Passed PR removes 34 lines of YAML CI config (duplicate job). No weak crypto (MD5/SHA1/DES/RC4/3DES/Blowfish/ECB), custom crypto, or timing attack vulnerabilities present.
Container-Privileges ✅ Passed The modified file (openshift-hive-master__periodic.yaml) is a ci-operator configuration file, not a Kubernetes/container manifest. It contains no Pod/Container definitions with privileged security...
No-Sensitive-Data-In-Logs ✅ Passed The PR introduces CI configuration with proper credential handling. No passwords, tokens, API keys, or other sensitive data are logged; credentials are securely mounted and referenced by file paths...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dlom and suhanime June 22, 2026 16:21
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miyadav
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@miyadav: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 22, 2026
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@miyadav: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants