Skip to content

Add odh-dashboard-operator to OpenShift CI image builds#80855

Open
lucferbux wants to merge 2 commits into
openshift:mainfrom
lucferbux:dashboard-operator-openshift-ci
Open

Add odh-dashboard-operator to OpenShift CI image builds#80855
lucferbux wants to merge 2 commits into
openshift:mainfrom
lucferbux:dashboard-operator-openshift-ci

Conversation

@lucferbux

@lucferbux lucferbux commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the dashboard-operator component from opendatahub-io/odh-dashboard to the CI image build and Quay mirror configuration.

Changes

  • New image: odh-dashboard-operator-image built from ./dashboard-operator/Dockerfile
  • PR mirror test: odh-dashboard-operator-pr-image-mirror — mirrors to quay.io/opendatahub/odh-dashboard-operator on PRs
  • Postsubmit mirror test: odh-dashboard-operator-image-mirror — mirrors to quay.io/opendatahub/odh-dashboard-operator on merge to main

Context

The dashboard-operator is a Go controller-runtime operator (Go 1.25, UBI9-minimal runtime) that lives alongside the main dashboard frontend in the opendatahub-io/odh-dashboard monorepo. It already has:

  • Upstream Dockerfile at dashboard-operator/Dockerfile
  • Tekton push/PR pipelines in .tekton/
  • Konflux onboarding in progress (RHOAIENG-69576, RHOAIENG-69580)

This PR adds the OpenShift CI configuration to build and mirror the operator image, following the same pattern as the existing modular-architecture package images.

Prerequisites

  • The opendatahub+openshift_ci Quay robot account needs push permission on quay.io/opendatahub/odh-dashboard-operator

Note

The prowgen-generated job files (presubmits.yaml / postsubmits.yaml) will need to be regenerated. Please run make jobs or let CI handle the regeneration.

/cc @opendatahub-io/odh-dashboard

Summary by CodeRabbit

This PR integrates the dashboard-operator component into the OpenShift CI infrastructure for the opendatahub-io/odh-dashboard repository by extending the CI configuration in opendatahub-io-odh-dashboard-main.yaml.

Changes Made

Image Build Configuration:

  • Adds a new CI image build entry for odh-dashboard-operator-image that sources from ./dashboard-operator/Dockerfile

Mirror Test Workflows:

  • PR Mirror Test (odh-dashboard-operator-pr-image-mirror): Runs on pull requests and mirrors built images to quay.io/opendatahub/odh-dashboard-operator
  • Postsubmit Mirror Test (odh-dashboard-operator-image-mirror): Runs on merge to main and mirrors images to the same Quay repository with RELEASE_VERSION: main tag

Both mirror tests use the existing opendatahub-io-ci-image-mirror workflow, following the established pattern for other modular architecture components (model-registry, gen-ai, maas, mlflow, eval-hub, automl, autorag, agent-ops) already configured in the same file.

Impact

This enables automated CI/CD for the dashboard-operator component: images are built during pull requests for testing and automatically published to Quay upon merge to the main branch. The Prow job files (presubmits.yaml and postsubmits.yaml) will be regenerated from this configuration, either locally via make jobs or through CI automation.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@lucferbux: GitHub didn't allow me to request PR reviews from the following users: opendatahub-io/odh-dashboard.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Summary

Add the dashboard-operator component from opendatahub-io/odh-dashboard to the CI image build and Quay mirror configuration.

Changes

  • New image: odh-dashboard-operator-image built from ./dashboard-operator/Dockerfile
  • PR mirror test: odh-dashboard-operator-pr-image-mirror — mirrors to quay.io/opendatahub/odh-dashboard-operator on PRs
  • Postsubmit mirror test: odh-dashboard-operator-image-mirror — mirrors to quay.io/opendatahub/odh-dashboard-operator on merge to main

Context

The dashboard-operator is a Go controller-runtime operator (Go 1.25, UBI9-minimal runtime) that lives alongside the main dashboard frontend in the opendatahub-io/odh-dashboard monorepo. It already has:

  • Upstream Dockerfile at dashboard-operator/Dockerfile
  • Tekton push/PR pipelines in .tekton/
  • Konflux onboarding in progress (RHOAIENG-69576, RHOAIENG-69580)

This PR adds the OpenShift CI configuration to build and mirror the operator image, following the same pattern as the existing modular-architecture package images.

Prerequisites

  • The opendatahub+openshift_ci Quay robot account needs push permission on quay.io/opendatahub/odh-dashboard-operator

Note

The prowgen-generated job files (presubmits.yaml / postsubmits.yaml) will need to be regenerated. Please run make jobs or let CI handle the regeneration.

/cc @opendatahub-io/odh-dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 28aa52ae-9848-432a-b755-67249385f94d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The CI operator config for opendatahub-io/odh-dashboard gains a new dashboard-operator image entry pointing to ./dashboard-operator/Dockerfile, producing odh-dashboard-operator-image. Two mirror test steps are added: one for PRs and one postsubmit (with RELEASE_VERSION: main), both using opendatahub-io-ci-image-mirror.

Changes

dashboard-operator image build and mirror registration

Layer / File(s) Summary
Image build entry and mirror test steps
ci-operator/config/opendatahub-io/odh-dashboard/opendatahub-io-odh-dashboard-main.yaml
Adds odh-dashboard-operator-image to the images list with its Dockerfile path, and appends PR and postsubmit opendatahub-io-ci-image-mirror test entries for that image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the main change: adding the odh-dashboard-operator component to OpenShift CI image builds, which is the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies CI configuration YAML, not Ginkgo tests. Custom check for Ginkgo test stability is not applicable to this CI config change.
Test Structure And Quality ✅ Passed This PR modifies only CI configuration YAML, not Ginkgo test code. The custom check is not applicable to this PR as it contains no test implementations or test framework code.
Microshift Test Compatibility ✅ Passed This PR modifies only CI configuration (YAML), not test code. No Ginkgo e2e tests are added, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies CI/CD YAML configuration files; no Ginkgo e2e tests are added, so SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies CI operator configuration file (image build and mirror test definitions), not deployment manifests, operator code, or controllers. Topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration file for image build and mirror tests. No test code or binary process code is changed, so OTE stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests; it only modifies CI configuration YAML to add image build and mirror workflow entries. The check is not applicable.
No-Weak-Crypto ✅ Passed PR only modifies YAML CI configuration; no weak crypto, custom implementations, or insecure token comparisons found.
Container-Privileges ✅ Passed No container privilege escalation settings found in the PR: no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or runAsRoot configurations detected in any YAML...
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data (passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data) found in the YAML configuration changes for the dashboard-operator CI image build and mirror...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@lucferbux: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

Generated via `make ci-operator-prowgen` to include:
- New presubmit job for odh-dashboard-operator-pr-image-mirror
- New postsubmit job for odh-dashboard-operator-image-mirror
- Updated sparse_checkout_files across all existing jobs
@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@lucferbux: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@lucferbux: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-operator-pr-image-mirror opendatahub-io/odh-dashboard presubmit Presubmit changed
pull-ci-opendatahub-io-odh-dashboard-main-images opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-dashboard-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-agent-ops-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-automl-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-autorag-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-eval-hub-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-gen-ai-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-maas-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-mlflow-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
pull-ci-opendatahub-io-odh-dashboard-main-odh-mod-arch-model-registry-pr-image-mirror opendatahub-io/odh-dashboard presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

@lucferbux: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ordered-prow-config 963b648 link true /test ordered-prow-config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant