NO-ISSUE: Consider centos-10 stream for OKD clusters - #31487
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@pablintino: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
ready-for-human-review
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe test now fetches cluster context before validation. It checks the ChangesStandalone OS validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 11❌ Failed checks (1 warning, 10 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/pipeline required |
|
Scheduling required tests: |
4ef1c9c to
09a3843
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pipeline required |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 09a3843
New tests seen in this PR at sha: 09a3843
|
09a3843 to
06e7ed3
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
06e7ed3 to
c30e4d8
Compare
|
/pipeline required |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Scheduling required tests: |
| clusterVersion, err := oc.AdminConfigClient().ConfigV1().ClusterVersions().Get(context.Background(), "version", metav1.GetOptions{}) | ||
| o.Expect(err).NotTo(o.HaveOccurred(), "Error getting ClusterVersion version singleton") | ||
|
|
||
| isOKD := strings.Contains(clusterVersion.Status.Desired.Version, "okd-scos") |
There was a problem hiding this comment.
It feels like these checks don't really belong in validateStandaloneNodeOS
Could this isOKD logic / name check be above https://github.com/pablintino/origin/blob/c30e4d8664ac0dd3ebda399ef73d8ab911ec3c12/test/extended/ci/job_names.go#L179
Understand that will lead to a duplicate isOKD check as you need that for the targetStream as well.
There was a problem hiding this comment.
Agree. I've moved the checks to the caller.
This change adds centos-10 as the expected stream of OKD jobs. From now, jobs named *okd* should always match the only available stream, centos-10. Signed-off-by: Pablo Rodriguez Nava <git@amail.pablintino.eu>
c30e4d8 to
f32f8cd
Compare
|
/pipeline required |
|
Scheduling required tests: |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
openshift-ci
Bot
added
the
approved
|
lol microshift does not have a /lgtm cancel |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: f32f8cd
New tests seen in this PR at sha: f32f8cd
|
|
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
This change adds centos-10 as the expected stream of OKD jobs. From now, jobs named okd should always match the only available stream, centos-10.
Summary by CodeRabbit
okd-scosjob naming.