OCPBUGS-84513: remove openshift-cluster-version terminationMessagePolicy exemption

[jrangelramos]

Summary

• Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

• Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload
• Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Updated test handling so containers in the openshift-cluster-version namespace are no longer exempt from an older violation pattern.
  • These cases will now be evaluated using the standard pass/fail logic, improving the accuracy of test results.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

• Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload
• Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 02ab71c6-e2e5-42f5-b52b-b05a3afc8d19

📥 Commits

Reviewing files that changed from the base of the PR and between 6bf37da and 737ed83.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

---

Walkthrough

A single-line removal eliminates the "openshift-cluster-version" grandfathered exception entry from the existingViolations map in the termination message policy monitor test, altering classification behavior for containers in that namespace.

Changes

Termination Message Policy Exception Removal

Layer / File(s)	Summary
Remove grandfathered exception entry pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Removes the existingViolations["openshift-cluster-version"] entry, causing containers in that namespace to be evaluated under standard fail/flake logic instead of being pre-exempted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the openshift-cluster-version terminationMessagePolicy exemption.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Changed file has no Ginkgo It/Describe/Context/When titles; the patch only removes one existingViolations map entry.
Test Structure And Quality	✅ Passed	Changed file is a monitor analyzer, not a Ginkgo spec; no It/BeforeEach/Eventually or cleanup patterns were modified, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	The PR only changes a monitor analyzer map entry; no new Ginkgo e2e tests or MicroShift-relevant test blocks were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only edits a monitor analyzer in pkg/monitortests; it adds no Ginkgo e2e tests or multi-node assumptions, and no SNO guard is needed.
Topology-Aware Scheduling Compatibility	✅ Passed	Change only removes a monitor-test exemption in a namespace map; it adds no manifests, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The touched file only removes a map entry; its init() just seeds a set, and no process-level stdout writes or logging setup were found.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo e2e test bodies were added; the change only removes a namespace exemption and introduces no IPv4 or external-connectivity assumptions.
No-Weak-Crypto	✅ Passed	Changed file only adjusts a monitor-test exemption; imports and content contain no weak crypto, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	PR touches only Go monitor tests; no manifests or privilege flags (privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation) were added.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: the patch only removes a namespace exemption; it adds no new logs or data-bearing output, and the touched file contains no secret/PII logging.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jrangelramos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-csi	737ed83	link	true	/test e2e-gcp-csi
ci/prow/e2e-gcp-ovn	737ed83	link	true	/test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn	737ed83	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn-upgrade	737ed83	link	true	/test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-microshift	737ed83	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-aws-csi	737ed83	link	true	/test e2e-aws-csi
ci/prow/e2e-metal-ipi-ovn-ipv6	737ed83	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-upi	737ed83	link	true	/test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.