USHIFT-7430: Fix uncore-cache test regex for kubelet JSON log format - #7117
USHIFT-7430: Fix uncore-cache test regex for kubelet JSON log format#7117copejon wants to merge 1 commit into
Conversation
The kubelet logs feature gates in JSON format with quoted keys
("CPUManagerPolicyBetaOptions":true), but the test pattern expected
unquoted format (CPUManagerPolicyBetaOptions:true), causing a
persistent mismatch and test failure.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@copejon: This pull request references USHIFT-7430 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe uncore-cache Robot test updates its kubelet log verification regex to match the quoted ChangesUncore-cache verification
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/test ? |
|
/test e2e-aws-tests-bootc-periodic-arm-el10 |
|
/lgtm Apply the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-tests-bootc-el10 |
|
/test e2e-aws-tests-bootc-periodic-el9 |
|
The failures were flakes unrelated to the PR's fix |
|
@copejon: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-tests-bootc-periodic-arm-el9 |
Summary
uncore-cache.robottest regex that fails to match kubelet's JSON-formatted feature gate log output"CPUManagerPolicyBetaOptions":true(JSON-quoted key), but the test pattern expectedCPUManagerPolicyBetaOptions:true(no quote before colon), causing a ~154s retry loop and test failureprefer-align-cpus-by-uncorecache":"true")Test plan
el98-src@low-latencyscenario passes in CI🤖 Generated with Claude Code
Summary by CodeRabbit
CPUManagerPolicyBetaOptions=true.