Skip to content

USHIFT-7430: Fix uncore-cache test regex for kubelet JSON log format - #7117

Open
copejon wants to merge 1 commit into
openshift:mainfrom
copejon:ushift-7430-fix-uncore-cache-regex
Open

USHIFT-7430: Fix uncore-cache test regex for kubelet JSON log format#7117
copejon wants to merge 1 commit into
openshift:mainfrom
copejon:ushift-7430-fix-uncore-cache-regex

Conversation

@copejon

@copejon copejon commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix uncore-cache.robot test regex that fails to match kubelet's JSON-formatted feature gate log output
  • The kubelet logs "CPUManagerPolicyBetaOptions":true (JSON-quoted key), but the test pattern expected CPUManagerPolicyBetaOptions:true (no quote before colon), causing a ~154s retry loop and test failure
  • Aligns with the existing pattern on line 70 which already uses JSON format (prefer-align-cpus-by-uncorecache":"true")

Test plan

  • Verify el98-src@low-latency scenario passes in CI

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated uncore-cache verification to recognize the current kubelet log format for CPUManagerPolicyBetaOptions=true.

The kubelet logs feature gates in JSON format with quoted keys
("CPUManagerPolicyBetaOptions":true), but the test pattern expected
unquoted format (CPUManagerPolicyBetaOptions:true), causing a
persistent mismatch and test failure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026

Copy link
Copy Markdown

@copejon: This pull request references USHIFT-7430 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Fix uncore-cache.robot test regex that fails to match kubelet's JSON-formatted feature gate log output
  • The kubelet logs "CPUManagerPolicyBetaOptions":true (JSON-quoted key), but the test pattern expected CPUManagerPolicyBetaOptions:true (no quote before colon), causing a ~154s retry loop and test failure
  • Aligns with the existing pattern on line 70 which already uses JSON format (prefer-align-cpus-by-uncorecache":"true")

Test plan

  • Verify el98-src@low-latency scenario passes in CI

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-ci
openshift-ci Bot requested review from agullon and jogeo July 29, 2026 01:14
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d8378ad9-77a5-445a-92e9-b103d6b9f785

📥 Commits

Reviewing files that changed from the base of the PR and between fef2239 and cf37123.

📒 Files selected for processing (1)
  • test/suites/tuned/uncore-cache.robot

Walkthrough

The uncore-cache Robot test updates its kubelet log verification regex to match the quoted CPUManagerPolicyBetaOptions":true format.

Changes

Uncore-cache verification

Layer / File(s) Summary
Kubelet log regex update
test/suites/tuned/uncore-cache.robot
The expected log pattern now matches the quoted CPU manager beta option key/value format.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing the uncore-cache test regex for kubelet JSON log output.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a Robot log regex changed; no Ginkgo-style titles or dynamic test names were added.
Test Structure And Quality ✅ Passed Not applicable: the changed test is Robot Framework, not Ginkgo, and it has no It/BeforeEach/Eventually/Expect constructs.
Microshift Test Compatibility ✅ Passed Only a log-regex change in an existing Robot test; no new Ginkgo tests, APIs, or unsupported MicroShift assumptions were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only a Robot test regex changed; no new Ginkgo e2e test or multi-node/SNO assumption was introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only a log-regex expectation changed in a test; no manifests, controllers, replicas, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only a Robot test regex changed; no main/init/TestMain/suite setup code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Patch only changes a Robot Framework log regex; no new Ginkgo e2e tests, IPv4-only logic, or external connectivity were added.
No-Weak-Crypto ✅ Passed Diff only changes a kubelet log regex in a Robot test; no weak-crypto algorithms, custom crypto, or secret comparisons are introduced.
Container-Privileges ✅ Passed Only test/suites/tuned/uncore-cache.robot changed; no K8s/container privilege fields or manifests are present in the touched file.
No-Sensitive-Data-In-Logs ✅ Passed Only a test regex changed to match kubelet JSON log syntax; no sensitive data appears to be added or logged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ggiguash

Copy link
Copy Markdown
Contributor

/test ?

@ggiguash

Copy link
Copy Markdown
Contributor

/test e2e-aws-tests-bootc-periodic-arm-el10
/test e2e-aws-tests-bootc-periodic-arm-el9
/test e2e-aws-tests-bootc-periodic-el10
/test e2e-aws-tests-bootc-periodic-el9

@ggiguash

Copy link
Copy Markdown
Contributor

/lgtm

Apply the verified label if the low-latency tests in periodics pass.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2026
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@copejon

copejon commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests-bootc-el10

@copejon

copejon commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests-bootc-periodic-el9
/test e2e-aws-tests-bootc-periodic-arm-el9

@copejon

copejon commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

The failures were flakes unrelated to the PR's fix

@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@copejon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-periodic-arm-el9 cf37123 link true /test e2e-aws-tests-bootc-periodic-arm-el9

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@copejon

copejon commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-tests-bootc-periodic-arm-el9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants