Skip to content

SPLAT-2582: Updated IPAM references to use v1beta2#1445

Open
vr4manta wants to merge 2 commits into
openshift:mainfrom
vr4manta:SPLAT-2582
Open

SPLAT-2582: Updated IPAM references to use v1beta2#1445
vr4manta wants to merge 2 commits into
openshift:mainfrom
vr4manta:SPLAT-2582

Conversation

@vr4manta

@vr4manta vr4manta commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

SPLAT-2582

Changes

  • Updated IPAM usage to use v1beta2 instead of v1beta1.

Notes

This is not a must have, but after recent bumps, we are getting a lot of warning messages about using the deprecated v1beta1 APIs.

After this change happens, installer will also need to be updated to generate IPAM v1beta2 versions of IPAddress and IPAddressClaims for vSphere static IP.

Currently vSphere static IP periodicals for 4.21+ are failing due to crd changes. Once those are fixed, this PR should have the static IP jobs pass with no warning messages for IPAddressClaims.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 8, 2025
@openshift-ci-robot

openshift-ci-robot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references SPLAT-2582 which is a valid jira issue.

Details

In response to this:

SPLAT-2582

Changes

  • Updated IPAM usage to use v1beta2 instead of v1beta1.

Notes

This is not a must have, but after recent bumps, we are getting a lot of warning messages about using the deprecated v1beta1 APIs.

After this change happens, installer will also need to be updated to generate IPAM v1beta2 versions of IPAddress and IPAddressClaims for vSphere static IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot

openshift-ci-robot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references SPLAT-2582 which is a valid jira issue.

Details

In response to this:

SPLAT-2582

Changes

  • Updated IPAM usage to use v1beta2 instead of v1beta1.

Notes

This is not a must have, but after recent bumps, we are getting a lot of warning messages about using the deprecated v1beta1 APIs.

After this change happens, installer will also need to be updated to generate IPAM v1beta2 versions of IPAddress and IPAddressClaims for vSphere static IP.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mdbooth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta

vr4manta commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn

@openshift-ci

openshift-ci Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-static-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91dca1f0-d460-11f0-9d86-f7e380d1078d-0

@openshift-ci-robot

openshift-ci-robot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@vr4manta: This pull request references SPLAT-2582 which is a valid jira issue.

Details

In response to this:

SPLAT-2582

Changes

  • Updated IPAM usage to use v1beta2 instead of v1beta1.

Notes

This is not a must have, but after recent bumps, we are getting a lot of warning messages about using the deprecated v1beta1 APIs.

After this change happens, installer will also need to be updated to generate IPAM v1beta2 versions of IPAddress and IPAddressClaims for vSphere static IP.

Currently vSphere static IP periodicals for 4.21+ are failing due to crd changes. Once those are fixed, this PR should have the static IP jobs pass with no warning messages for IPAddressClaims.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta

vr4manta commented Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

Not sure why the TestReconcile/machine_with_node_likely_to_go_unhealthy test failed. I"ll retry later.

@damdo

damdo commented Dec 9, 2025

Copy link
Copy Markdown
Member

/test unit

@damdo

damdo commented Dec 9, 2025

Copy link
Copy Markdown
Member

/hold

We are working on a different fix, will keep you posted

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2025
@damdo

damdo commented Dec 9, 2025

Copy link
Copy Markdown
Member

cc. @mdbooth

@vr4manta

vr4manta commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@vr4manta

vr4manta commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

/retest

@vr4manta

vr4manta commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Taking a deeper look at unit test issues

@vr4manta

vr4manta commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

@damdo now that things have settled down, do we want to look into using this PR?

@vr4manta

vr4manta commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo

damdo commented Mar 7, 2026

Copy link
Copy Markdown
Member

@vr4manta yes we may wanna still do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants