Skip to content

OLS-3593 enable init container comparison for app server deployment - #1897

Open
raptorsun wants to merge 1 commit into
openshift:mainfrom
raptorsun:OLS-3593-fix-rag-init-container-reconciliation
Open

OLS-3593 enable init container comparison for app server deployment#1897
raptorsun wants to merge 1 commit into
openshift:mainfrom
raptorsun:OLS-3593-fix-rag-init-container-reconciliation

Conversation

@raptorsun

Copy link
Copy Markdown
Contributor

Summary

  • Fix: enable init container comparison in the app server deployment update check so that changes to .spec.ols.rag (RAG image references) trigger a deployment rollout
  • Root cause: DeploymentSpecEqual was called with compareInitContainers=false, so RAG init container changes were never detected

Test plan

  • make test passes — all unit tests green
  • Deploy OLS with a RAG image configured, change the image tag, and verify the operator rolls out a new deployment

Fixes: OLS-3593

🤖 Generated with Claude Code

The app server deployment update check was calling
DeploymentSpecEqual with compareInitContainers=false, which meant
changes to RAG images in .spec.ols.rag were never detected. This
prevented deployment rollouts when RAG image references changed.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@raptorsun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f6e8f310-4448-4367-a3e5-e2b0a5534912

📥 Commits

Reviewing files that changed from the base of the PR and between bfdf18f and 56a1912.

📒 Files selected for processing (1)
  • internal/controller/appserver/deployment.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bparees and xrajesh July 30, 2026 16:16
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raptorsun

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@raptorsun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bundle-e2e-4-21 56a1912 link true /test bundle-e2e-4-21

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant