OLS-3089 Disable SA token automount for non-API pods - #1893
Conversation
Set automountServiceAccountToken=false on PostgreSQL, console, agentic-console, and OTEL collector PodSpecs. These pods do not make Kubernetes API calls and should not mount service account tokens. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe pod templates generated for the OTEL Collector, Postgres, and console plugin now explicitly disable automatic service account token mounting while retaining existing service account configuration. ChangesService account token automounting
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@xrajesh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
automountServiceAccountToken=falseon PostgreSQL, console, agentic-console, and OTEL collector PodSpecs. These pods serve static files or run databases and do not make Kubernetes API calls, so they should not mount service account tokens.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit