Update kubernetes monorepo to v0.36.3 - #381
Conversation
red-hat-konflux
Bot
added
approved
ℹ️ Artifact update noticeFile name: api/go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
File name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe root and API Go modules now target Go 1.26.0. Selected Kubernetes dependencies were upgraded from v0.35.3 to v0.36.3, and two indirect root dependencies were removed. ChangesGo module and dependency updates
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 3: Update the Go version declaration in go.mod at line 3, api/go.mod at
line 3, and the release workflow’s Go setup at .github/workflows/release-cli.yml
line 28 to the same patched Go 1.26.x release, replacing 1.26.0 consistently
across all three locations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 425437e5-e5db-469a-b7da-1ef4104307e5
⛔ Files ignored due to path filters (2)
api/go.sumis excluded by!**/*.sum,!api/go.sumgo.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (2)
api/go.modgo.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
|
/hold Revision 12804c1 was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
12804c1 to
89b89a1
Compare
|
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
api/go.mod (1)
5-7: 🔒 Security & Privacy | 🔵 TrivialComplete the required dependency supply-chain checks.
Verify
go.sumintegrity, OSV advisories for both Kubernetes modules, license compatibility, SBOM/provenance attestations, and Sigstore/cosign signing in the release pipeline before merging.As per path instructions: “Pin exact versions; verify hashes where supported; flag known CVEs (cross-ref osv.dev); ensure build produces provenance attestations; artifacts signed with Sigstore/cosign.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/go.mod` around lines 5 - 7, Complete supply-chain validation for the exact Kubernetes dependencies declared in the require block: verify go.sum hashes, check both modules against OSV advisories, confirm license compatibility, and add release-pipeline checks for SBOM/provenance attestations and Sigstore/cosign artifact signing. Ensure the pipeline blocks merging or release when any required verification fails.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/go.mod`:
- Around line 5-7: Update the k8s.io/apiextensions-apiserver requirement in the
go.mod require block from v0.35.3 to v0.36.3, matching k8s.io/apimachinery and
keeping both Kubernetes modules on the same minor version.
---
Nitpick comments:
In `@api/go.mod`:
- Around line 5-7: Complete supply-chain validation for the exact Kubernetes
dependencies declared in the require block: verify go.sum hashes, check both
modules against OSV advisories, confirm license compatibility, and add
release-pipeline checks for SBOM/provenance attestations and Sigstore/cosign
artifact signing. Ensure the pipeline blocks merging or release when any
required verification fails.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 32b51f1e-9a05-4afa-92ce-e2c53372b71d
⛔ Files ignored due to path filters (2)
api/go.sumis excluded by!**/*.sum,!api/go.sumgo.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (2)
api/go.modgo.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
🚧 Files skipped from review as they are similar to previous changes (1)
- go.mod
89b89a1 to
5b96b69
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/go.mod`:
- Around line 6-7: Update the sigs.k8s.io/controller-runtime dependency in
api/go.mod from v0.23.3 to the compatible v0.24.x release for Kubernetes
v0.36.3, then regenerate api/go.sum to reflect the updated module dependencies.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 5c2a91fc-94da-4be8-b0f6-8157306b1463
⛔ Files ignored due to path filters (2)
api/go.sumis excluded by!**/*.sum,!api/go.sumgo.sumis excluded by!**/*.sum,!go.sum
📒 Files selected for processing (2)
api/go.modgo.mod
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
| k8s.io/apiextensions-apiserver v0.36.3 | ||
| k8s.io/apimachinery v0.36.3 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
(cd api && go list -m all | rg 'k8s.io/(api|apimachinery)|sigs.k8s.io/controller-runtime')Repository: openshift/lightspeed-agentic-operator
Length of output: 389
Upgrade controller-runtime to match Kubernetes v0.36
api/go.mod is on Kubernetes v0.36.3, but sigs.k8s.io/controller-runtime is still pinned to v0.23.3. Bump it to the v0.24.x line and regenerate go.sum so the module set stays compatible.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@api/go.mod` around lines 6 - 7, Update the sigs.k8s.io/controller-runtime
dependency in api/go.mod from v0.23.3 to the compatible v0.24.x release for
Kubernetes v0.36.3, then regenerate api/go.sum to reflect the updated module
dependencies.
a9ff077 to
15835b1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
8d1274e to
7d2c24f
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
7d2c24f to
b47a2d0
Compare
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v0.35.3→v0.36.3v0.35.3→v0.36.3v0.35.3→v0.36.3v0.35.3→v0.36.3v0.35.3→v0.36.3Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes/api (k8s.io/api)
v0.36.3Compare Source
v0.36.2Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.7Compare Source
v0.35.6Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
kubernetes/apiextensions-apiserver (k8s.io/apiextensions-apiserver)
v0.36.3Compare Source
v0.36.2Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.7Compare Source
v0.35.6Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.36.3Compare Source
v0.36.2Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.7Compare Source
v0.35.6Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
kubernetes/cli-runtime (k8s.io/cli-runtime)
v0.36.3Compare Source
v0.36.2Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.7Compare Source
v0.35.6Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.36.3Compare Source
v0.36.2Compare Source
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.7Compare Source
v0.35.6Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.