Add staging environment support and existing COS instance configuration - #10716
Open
taliandre49 wants to merge 5 commits into
Open
Add staging environment support and existing COS instance configuration#10716taliandre49 wants to merge 5 commits into
taliandre49 wants to merge 5 commits into
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughChangesThe installer adds IBM Cloud staging endpoint support and reusable COS instance CRNs for IBM Cloud and PowerVS. Validation, provisioning, metadata, manifests, controller wiring, destruction, Kubernetes schemas, and documentation are updated. IBM Cloud lifecycle changes
Estimated code review effort: 4 (Complex) | ~60 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (2 errors)
✅ Passed checks (13 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go (1)
519-565: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winDestroyBootstrap never looks up the COS instance by CRN, breaking cleanup for user-provided COS instances.
userProvidedCOSis computed at line 521, but the instance lookup right above/below it always callsclient.GetCOSInstanceByName(ctx, cosInstanceName)using the auto-generated<infraID>-cosname — it never callsclient.GetResourceInstance(ctx, CRN)the wayPreProvision/Ignitiondo. If the user's existing COS instance name doesn't match that convention,GetCOSInstanceByNamereturnsCOSResourceNotFoundError, which the switch treats as fatal and returns early — skipping ignition-bucket cleanup, security-group cleanup, and floating-IP cleanup entirely.🐛 Proposed fix: resolve the COS instance by CRN when user-provided
- cosInstanceName := ibmcloudic.COSInstanceName(infraID) bucketName := ibmcloudbootstrap.GetIgnitionBucketName(infraID) - // Get COS Instance ID - logrus.Debugf("bootstrap destroy check cos resources for %s/%s", cosInstanceName, bucketName) - cosInstanceDetails, err := client.GetCOSInstanceByName(ctx, cosInstanceName) - switch { - case err != nil: - return fmt.Errorf("failed retrieving cos instance for destroy bootstrap: %w", err) - case cosInstanceDetails != nil: - err = cleanupIgnitionCOSBucket(ctx, client, *cosInstanceDetails.ID, bucketName, region) - if err != nil { - return fmt.Errorf("failed to cleanup bootstrap ignition cos bucket %s: %w", bucketName, err) - } - logrus.Debugf("cleaned up bootstrap ignition cos bucket: %s/%s", *cosInstanceDetails.ID, bucketName) - default: - logrus.Debugf("no cos instance found for the cluster as %s, skipping ignition bucket cleanup", cosInstanceName) - } + var cosInstanceDetails *resourcecontrollerv2.ResourceInstance + if userProvidedCOS { + cosInstanceDetails, err = client.GetResourceInstance(ctx, in.Metadata.IBMCloud.COSInstanceCRN) + if err != nil { + return fmt.Errorf("failed retrieving user-provided cos instance for destroy bootstrap: %w", err) + } + } else { + cosInstanceName := ibmcloudic.COSInstanceName(infraID) + logrus.Debugf("bootstrap destroy check cos resources for %s/%s", cosInstanceName, bucketName) + cosInstanceDetails, err = client.GetCOSInstanceByName(ctx, cosInstanceName) + if err != nil { + return fmt.Errorf("failed retrieving cos instance for destroy bootstrap: %w", err) + } + } + if cosInstanceDetails != nil { + if err := cleanupIgnitionCOSBucket(ctx, client, *cosInstanceDetails.ID, bucketName, region); err != nil { + return fmt.Errorf("failed to cleanup bootstrap ignition cos bucket %s: %w", bucketName, err) + } + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go` around lines 519 - 565, Update DestroyBootstrap’s COS lookup to resolve the user-provided instance via client.GetResourceInstance using COSInstanceCRN when userProvidedCOS is true, instead of calling GetCOSInstanceByName with the generated name. Retain the generated-name lookup for managed instances, and pass the resolved instance ID through bucket and instance cleanup so later cleanup steps are not skipped.pkg/asset/installconfig/powervs/session.go (1)
475-496: 🩺 Stability & Availability | 🔴 Critical | ⚡ Quick winEnabling endpoint overrides the code itself documents as broken.
ResourceControllerandResourceManagerare now mapped to active"rc"/"rm"CAPI overrides, but the inline comments say"rc,"crashes CAPI and"rm"leaves masters unable to get their ignition. If a user (or the staging config) supplies either endpoint override, this will pass it straight through to CAPI with a known-bad outcome.Either keep these disabled (empty string, as before) until the CAPI-side issue is fixed, or gate them behind a resolved fix.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/installconfig/powervs/session.go` around lines 475 - 496, Update MapServiceEndpointsForCAPI’s capiSupported mapping to keep ResourceController and ResourceManager disabled by assigning empty values, so their known-broken rc/rm overrides are skipped until the CAPI issues are resolved. Preserve the existing mappings and unsupported-endpoint logging.
🧹 Nitpick comments (5)
pkg/asset/installconfig/ibmcloud/validation.go (1)
500-502: 🩺 Stability & Availability | 🔵 Trivial | 🏗️ Heavy liftPropagate cancellation into validation.
context.TODO()disconnects the resource lookup from install-command cancellation. Thread a callercontext.ContextthroughValidate,validatePlatform, andvalidateCOSInstanceCRN; retain the client timeout as a bound.As per path instructions, Go external calls must support context cancellation and timeouts.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/installconfig/ibmcloud/validation.go` around lines 500 - 502, Replace context.TODO() in validateCOSInstanceCRN with a caller-provided context, and thread that context through Validate and validatePlatform into the COS resource lookup. Preserve the existing client timeout as an additional bound while ensuring cancellation from the install command reaches client.GetResourceInstance.Source: Path instructions
pkg/asset/installconfig/powervs/staging.go (1)
92-125: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove the commented-out
GetCOSDirectEndpointblock.34 lines of dead, commented-out code add noise for future maintainers. If this is planned for later use, track it in an issue/TODO instead of leaving it in-tree.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/installconfig/powervs/staging.go` around lines 92 - 125, Remove the entire commented-out GetCOSDirectEndpoint block, including its documentation and implementation, while leaving surrounding active code unchanged.pkg/clusterapi/system.go (1)
356-382: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicated IAM env-var construction; consider a shared helper.
Both the
ibmcloud.Nameandpowervs.Namebranches build near-identicalenvVarsmaps (auth type, API key, IAM URL/endpoint, log level, optionalIBMCLOUD_STAGING). Also worth noting: only theibmcloud.Namebranch appliesCheckServiceEndpointOverrideon top ofGetIAMURL()(line 359) — thepowervs.Namebranch doesn't, which may or may not be intentional given PowerVS has its own endpoint-override plumbing elsewhere.♻️ Suggested extraction
func buildIBMCloudEnvVars(apiKey, iamEndpoint, logLevel string) map[string]string { envVars := map[string]string{ "IBMCLOUD_AUTH_TYPE": "iam", "IBMCLOUD_APIKEY": apiKey, "IBMCLOUD_AUTH_URL": iamEndpoint, "IBMCLOUD_IAM_API_ENDPOINT": iamEndpoint, "LOGLEVEL": logLevel, } if stagingEnv := os.Getenv("IBMCLOUD_STAGING"); stagingEnv != "" { envVars["IBMCLOUD_STAGING"] = stagingEnv } return envVars }Also applies to: 445-471
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/clusterapi/system.go` around lines 356 - 382, The IAM environment-variable maps are duplicated between the ibmcloud.Name and powervs.Name branches. Extract their shared construction, including optional IBMCLOUD_STAGING propagation, into a helper and use it from both branches; preserve each branch’s existing IAM endpoint selection and override behavior, and retain the current log-level value.pkg/asset/installconfig/powervs/client.go (1)
804-823: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winResource Manager client uses
GetResourceControllerURL()instead of the dedicatedGetResourceManagerURL().
destroy/powervs/powervs.go's equivalentloadSDKServicescorrectly callspowervs.GetResourceManagerURL()for this same client. Both helpers currently return the same host, so this isn't broken today, but relying on the wrong helper here is a landmine if the two endpoints ever diverge (e.g., a future staging config split).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/asset/installconfig/powervs/client.go` around lines 804 - 823, Update loadResourceManagementAPI to initialize ResourceManagerV2Options.URL with GetResourceManagerURL() instead of GetResourceControllerURL(). Leave the IAM URL and client initialization flow unchanged.pkg/infrastructure/powervs/clusterapi/powervs.go (1)
96-119: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove or properly gate the commented-out staging COS ACL block.
This is dead code checked into
InfraReady. It also callsSetCOSBucketPublicIAMPolicy, which currently has a URL-construction bug (seeclient.go) — if someone uncomments this later without noticing, it will silently fail. Prefer removing it or wiring it behind a real, tested staging conditional rather than leaving it commented.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@pkg/infrastructure/powervs/clusterapi/powervs.go` around lines 96 - 119, Remove the commented-out staging COS ACL block from InfraReady, including the SetCOSBucketPublicIAMPolicy call and related logging, rather than retaining dead code with a known URL-construction issue. Keep the active InfraReady behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user/ibmcloud/existing-cos-instance.md`:
- Around line 28-43: Update the Configuration example around cosInstanceCRN so
its documented platform path matches the stated platform.ibmcloud path; replace
platform.powerVS with platform.ibmcloud while preserving the existing field and
YAML structure.
- Line 42: Correct the sample CRNs in the documented examples, including both
occurrences, by removing one trailing colon so each ends with <instance_id>::
rather than <instance_id>:::. Keep the remaining CRN structure unchanged.
In `@pkg/asset/installconfig/ibmcloud/client.go`:
- Line 134: The default IAM endpoint in
pkg/asset/installconfig/ibmcloud/client.go at lines 134-134 must remain the
production URL; select the staging endpoint only through explicit configuration.
Update the shell fallback in
data/data/cluster-api/ibmcloud-infrastructure-components.yaml at lines 8105-8105
to use the production IAM host, preserving explicit endpoint overrides.
- Line 1541: Remove the uncontrolled fmt.Printf debug output from the endpoint
override handling in pkg/asset/installconfig/ibmcloud/client.go:1541 and replace
endpoint-override reporting with safe logging that excludes URLs, internal
endpoints, and customer resource identifiers. Apply the same safe logging change
to the corresponding endpoint override handling in
pkg/asset/installconfig/ibmcloud/validation.go:484.
In `@pkg/asset/installconfig/ibmcloud/metadata.go`:
- Around line 298-306: Remove the personal debug output from GetIAMToken in
pkg/asset/installconfig/ibmcloud/metadata.go, including the authenticator print
that exposes the IAM API key; remove the debug print before the IAM token call
in Ignition in pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go; remove the
POWEROVERRIDE print in GetPowerURL in pkg/asset/installconfig/powervs/staging.go
and delete the fmt import there if unused afterward.
In `@pkg/asset/installconfig/ibmcloud/validation.go`:
- Around line 487-505: Update the CRN validation in the relevant validation
function to enforce the complete anchored, allow-listed COS CRN shape, including
the expected IBM Cloud COS service and required segments, instead of only
checking the crn: prefix and length. After client.GetResourceInstance succeeds,
validate that the returned resource is identified as a COS instance before
accepting it; report malformed or non-COS resources through the existing
field.Invalid path.
In `@pkg/asset/installconfig/powervs/client.go`:
- Around line 35-53: Update loggingTransport.RoundTrip to redact the
Authorization header value before logging request headers, while preserving
other header diagnostics and request behavior. Remove the leftover “Test: Try to
get a token first” RequestToken probe from the GetDNSZones setup so each DNS
instance does not perform an unnecessary IAM round-trip.
- Around line 927-931: Update GetAuthenticatorAPIKeyDetails to use the
environment-aware GetIAMURL() value for the IAM authenticator URL instead of the
hardcoded staging endpoint, matching the other authenticators in Client and
preserving mode-specific API-key lookups.
- Around line 1742-1815: Update SetCOSBucketPublicIAMPolicy so
core.IamAuthenticator.URL receives the base iamURL directly, without appending
/identity/token; leave the SDK responsible for adding the token endpoint before
CreatePolicyWithContext runs.
- Around line 1524-1532: Prevent malformed staging endpoints by updating
GetPowerURL in pkg/asset/installconfig/powervs/staging.go to resolve every
supported zone, or reject unsupported zones before URL construction; do not
ignore its region parameter when it can provide a valid fallback. Remove the
leftover debug fmt.Printf. Apply the validation consistently at
pkg/asset/installconfig/powervs/client.go:1524-1532,
pkg/asset/installconfig/powervs/session.go:202-229, and
pkg/destroy/powervs/powervs.go:558-564 so NewPISession, CreateSSHKey, and
destroy flows never receive an empty datacenter prefix.
In `@pkg/asset/installconfig/powervs/session.go`:
- Around line 91-95: Replace the unverified parsing in the token-handling flow
around jwt.Parser and ParseUnverified with signature-validated JWT parsing for
all environments. Configure the parser’s trusted signing key or
environment-specific key selection, including the staging IAM key through
existing configuration, while preserving downstream claims extraction only after
successful verification.
In `@pkg/asset/installconfig/powervs/staging.go`:
- Around line 128-174: Update GetPowerURL so staging-mode zones not found in
zoneToDC do not produce a URL with an empty datacenter prefix. Detect an
unmapped zone and apply the established sensible fallback, or fail explicitly
according to the surrounding configuration conventions; preserve the existing
mapped-zone URL behavior and production region URL path.
In `@pkg/infrastructure/powervs/clusterapi/powervs.go`:
- Around line 68-70: Update Provider.ProvisionTimeout to retain the existing
15-minute timeout for production and other platforms, and apply the 60-minute
value only when the staging environment requires it. Use the provider’s existing
environment or platform configuration to select the timeout rather than changing
the global default.
In `@pkg/types/ibmcloud/platform.go`:
- Around line 183-189: Update DestroyBootstrap in the IBM Cloud clusterapi
infrastructure flow to resolve the COS instance using COSInstanceCRN when it is
provided, instead of relying on the generated InfraID-derived name. Preserve
bootstrap bucket cleanup for user-provided instances, while skipping only
deletion of the existing COS instance; retain current name-based lookup and
deletion behavior when COSInstanceCRN is unset.
---
Outside diff comments:
In `@pkg/asset/installconfig/powervs/session.go`:
- Around line 475-496: Update MapServiceEndpointsForCAPI’s capiSupported mapping
to keep ResourceController and ResourceManager disabled by assigning empty
values, so their known-broken rc/rm overrides are skipped until the CAPI issues
are resolved. Preserve the existing mappings and unsupported-endpoint logging.
In `@pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go`:
- Around line 519-565: Update DestroyBootstrap’s COS lookup to resolve the
user-provided instance via client.GetResourceInstance using COSInstanceCRN when
userProvidedCOS is true, instead of calling GetCOSInstanceByName with the
generated name. Retain the generated-name lookup for managed instances, and pass
the resolved instance ID through bucket and instance cleanup so later cleanup
steps are not skipped.
---
Nitpick comments:
In `@pkg/asset/installconfig/ibmcloud/validation.go`:
- Around line 500-502: Replace context.TODO() in validateCOSInstanceCRN with a
caller-provided context, and thread that context through Validate and
validatePlatform into the COS resource lookup. Preserve the existing client
timeout as an additional bound while ensuring cancellation from the install
command reaches client.GetResourceInstance.
In `@pkg/asset/installconfig/powervs/client.go`:
- Around line 804-823: Update loadResourceManagementAPI to initialize
ResourceManagerV2Options.URL with GetResourceManagerURL() instead of
GetResourceControllerURL(). Leave the IAM URL and client initialization flow
unchanged.
In `@pkg/asset/installconfig/powervs/staging.go`:
- Around line 92-125: Remove the entire commented-out GetCOSDirectEndpoint
block, including its documentation and implementation, while leaving surrounding
active code unchanged.
In `@pkg/clusterapi/system.go`:
- Around line 356-382: The IAM environment-variable maps are duplicated between
the ibmcloud.Name and powervs.Name branches. Extract their shared construction,
including optional IBMCLOUD_STAGING propagation, into a helper and use it from
both branches; preserve each branch’s existing IAM endpoint selection and
override behavior, and retain the current log-level value.
In `@pkg/infrastructure/powervs/clusterapi/powervs.go`:
- Around line 96-119: Remove the commented-out staging COS ACL block from
InfraReady, including the SetCOSBucketPublicIAMPolicy call and related logging,
rather than retaining dead code with a known URL-construction issue. Keep the
active InfraReady behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: b3fe8d90-0d38-4feb-ac8d-500a31feb5c9
⛔ Files ignored due to path filters (16)
cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/clients/instance/ibm-pi-image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/session.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/utils.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_delete_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_get_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_events/pcloud_events_getquery_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_images/p_cloud_images_client.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_cluster.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_machine.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/controllers/ibmpowervsimage_controller.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/authenticator/authenticator.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/cos/service.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/resourcecontroller/service.gois excluded by!**/vendor/**data/data/install.openshift.io_installconfigs.yamlis excluded by!data/data/install.openshift.io_installconfigs.yamlvendor/github.com/openshift/api/config/v1/types.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (33)
.gitignorecmd/openshift-install/command/log.gocmd/openshift-install/main.godata/data/_configs.yamldata/data/_installationconfigs.yamldata/data/cluster-api/ibmcloud-infrastructure-components.yamldocs/user/ibmcloud/existing-cos-instance.mdpkg/asset/cluster/ibmcloud/ibmcloud.gopkg/asset/cluster/powervs/powervs.gopkg/asset/installconfig/ibmcloud/client.gopkg/asset/installconfig/ibmcloud/metadata.gopkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.gopkg/asset/installconfig/ibmcloud/validation.gopkg/asset/installconfig/platformcredscheck.gopkg/asset/installconfig/powervs/client.gopkg/asset/installconfig/powervs/mock/powervsclient_generated.gopkg/asset/installconfig/powervs/platform.gopkg/asset/installconfig/powervs/session.gopkg/asset/installconfig/powervs/staging.gopkg/asset/manifests/infrastructure.gopkg/asset/manifests/powervs/cluster.gopkg/asset/releaseimage/default.gopkg/clusterapi/system.gopkg/destroy/powervs/cloud-object-storage.gopkg/destroy/powervs/powervs.gopkg/destroy/powervs/serviceinstance.gopkg/infrastructure/ibmcloud/clusterapi/clusterapi.gopkg/infrastructure/powervs/clusterapi/powervs.gopkg/types/ibmcloud/metadata.gopkg/types/ibmcloud/metadata_test.gopkg/types/ibmcloud/platform.gopkg/types/powervs/metadata.gopkg/types/powervs/platform.go
taliandre49
force-pushed
the
staging-support-endpoints
branch
from
July 27, 2026 15:26
9269247 to
22655f1
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/asset/cluster/powervs/powervs.go`:
- Line 64: Add unit coverage for the PowerVS asset generation path that
populates COSInstanceCRN in uninstall metadata. In the pkg/asset/cluster/powervs
test suite, configure an install-config PowerVS COSInstanceCRN, invoke the
relevant asset-generation function, and assert the resulting metadata preserves
the same value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 685c584d-754e-41e3-8c82-fb6485f61405
⛔ Files ignored due to path filters (16)
cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/clients/instance/ibm-pi-image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/session.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/utils.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_delete_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_get_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_events/pcloud_events_getquery_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_images/p_cloud_images_client.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_cluster.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_machine.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/controllers/ibmpowervsimage_controller.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/authenticator/authenticator.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/cos/service.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/resourcecontroller/service.gois excluded by!**/vendor/**data/data/install.openshift.io_installconfigs.yamlis excluded by!data/data/install.openshift.io_installconfigs.yamlvendor/github.com/openshift/api/config/v1/types.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (33)
.gitignorecmd/openshift-install/command/log.gocmd/openshift-install/main.godata/data/_configs.yamldata/data/_installationconfigs.yamldata/data/cluster-api/ibmcloud-infrastructure-components.yamldocs/user/ibmcloud/existing-cos-instance.mdpkg/asset/cluster/ibmcloud/ibmcloud.gopkg/asset/cluster/powervs/powervs.gopkg/asset/installconfig/ibmcloud/client.gopkg/asset/installconfig/ibmcloud/metadata.gopkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.gopkg/asset/installconfig/ibmcloud/validation.gopkg/asset/installconfig/platformcredscheck.gopkg/asset/installconfig/powervs/client.gopkg/asset/installconfig/powervs/mock/powervsclient_generated.gopkg/asset/installconfig/powervs/platform.gopkg/asset/installconfig/powervs/session.gopkg/asset/installconfig/powervs/staging.gopkg/asset/manifests/infrastructure.gopkg/asset/manifests/powervs/cluster.gopkg/asset/releaseimage/default.gopkg/clusterapi/system.gopkg/destroy/powervs/cloud-object-storage.gopkg/destroy/powervs/powervs.gopkg/destroy/powervs/serviceinstance.gopkg/infrastructure/ibmcloud/clusterapi/clusterapi.gopkg/infrastructure/powervs/clusterapi/powervs.gopkg/types/ibmcloud/metadata.gopkg/types/ibmcloud/metadata_test.gopkg/types/ibmcloud/platform.gopkg/types/powervs/metadata.gopkg/types/powervs/platform.go
🚧 Files skipped from review as they are similar to previous changes (31)
- pkg/types/powervs/platform.go
- pkg/types/ibmcloud/platform.go
- pkg/asset/cluster/ibmcloud/ibmcloud.go
- pkg/asset/installconfig/ibmcloud/metadata.go
- data/data/_installationconfigs.yaml
- pkg/asset/installconfig/platformcredscheck.go
- cmd/openshift-install/command/log.go
- pkg/asset/manifests/powervs/cluster.go
- pkg/infrastructure/powervs/clusterapi/powervs.go
- pkg/asset/installconfig/ibmcloud/validation.go
- pkg/types/powervs/metadata.go
- pkg/types/ibmcloud/metadata.go
- pkg/asset/installconfig/powervs/platform.go
- pkg/destroy/powervs/serviceinstance.go
- pkg/asset/releaseimage/default.go
- pkg/asset/manifests/infrastructure.go
- pkg/types/ibmcloud/metadata_test.go
- .gitignore
- data/data/_configs.yaml
- pkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.go
- pkg/clusterapi/system.go
- pkg/destroy/powervs/cloud-object-storage.go
- data/data/cluster-api/ibmcloud-infrastructure-components.yaml
- pkg/asset/installconfig/ibmcloud/client.go
- docs/user/ibmcloud/existing-cos-instance.md
- cmd/openshift-install/main.go
- pkg/asset/installconfig/powervs/session.go
- pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go
- pkg/asset/installconfig/powervs/staging.go
- pkg/destroy/powervs/powervs.go
- pkg/asset/installconfig/powervs/client.go
Contributor
Author
|
status: Addressing issues |
taliandre49
force-pushed
the
staging-support-endpoints
branch
2 times, most recently
from
July 27, 2026 17:49
ec6d679 to
35a305c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/asset/installconfig/powervs/session.go`:
- Around line 481-482: Disable the ResourceController and ResourceManager
mappings in MapServiceEndpointsForCAPI so rc and rm are no longer appended
through --service-endpoint. Remove or gate both mappings while preserving all
other service-endpoint translations until the bundled CAPI provider supports
them.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 75173ba4-496f-4b4b-81b9-031f79eea072
⛔ Files ignored due to path filters (16)
cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/clients/instance/ibm-pi-image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/session.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/utils.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_delete_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_get_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_events/pcloud_events_getquery_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_images/p_cloud_images_client.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_cluster.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_machine.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/controllers/ibmpowervsimage_controller.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/authenticator/authenticator.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/cos/service.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/resourcecontroller/service.gois excluded by!**/vendor/**data/data/install.openshift.io_installconfigs.yamlis excluded by!data/data/install.openshift.io_installconfigs.yamlvendor/github.com/openshift/api/config/v1/types.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (33)
.gitignorecmd/openshift-install/command/log.gocmd/openshift-install/main.godata/data/_configs.yamldata/data/_installationconfigs.yamldata/data/cluster-api/ibmcloud-infrastructure-components.yamldocs/user/ibmcloud/existing-cos-instance.mdpkg/asset/cluster/ibmcloud/ibmcloud.gopkg/asset/cluster/powervs/powervs.gopkg/asset/installconfig/ibmcloud/client.gopkg/asset/installconfig/ibmcloud/metadata.gopkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.gopkg/asset/installconfig/ibmcloud/validation.gopkg/asset/installconfig/platformcredscheck.gopkg/asset/installconfig/powervs/client.gopkg/asset/installconfig/powervs/mock/powervsclient_generated.gopkg/asset/installconfig/powervs/platform.gopkg/asset/installconfig/powervs/session.gopkg/asset/installconfig/powervs/staging.gopkg/asset/manifests/infrastructure.gopkg/asset/manifests/powervs/cluster.gopkg/asset/releaseimage/default.gopkg/clusterapi/system.gopkg/destroy/powervs/cloud-object-storage.gopkg/destroy/powervs/powervs.gopkg/destroy/powervs/serviceinstance.gopkg/infrastructure/ibmcloud/clusterapi/clusterapi.gopkg/infrastructure/powervs/clusterapi/powervs.gopkg/types/ibmcloud/metadata.gopkg/types/ibmcloud/metadata_test.gopkg/types/ibmcloud/platform.gopkg/types/powervs/metadata.gopkg/types/powervs/platform.go
🚧 Files skipped from review as they are similar to previous changes (31)
- pkg/asset/cluster/powervs/powervs.go
- cmd/openshift-install/command/log.go
- pkg/asset/installconfig/platformcredscheck.go
- pkg/asset/cluster/ibmcloud/ibmcloud.go
- pkg/asset/manifests/powervs/cluster.go
- pkg/asset/manifests/infrastructure.go
- pkg/types/powervs/platform.go
- pkg/asset/installconfig/ibmcloud/metadata.go
- pkg/asset/releaseimage/default.go
- pkg/types/ibmcloud/metadata_test.go
- pkg/types/ibmcloud/metadata.go
- .gitignore
- cmd/openshift-install/main.go
- pkg/infrastructure/powervs/clusterapi/powervs.go
- pkg/types/ibmcloud/platform.go
- data/data/_installationconfigs.yaml
- pkg/asset/installconfig/ibmcloud/validation.go
- data/data/cluster-api/ibmcloud-infrastructure-components.yaml
- docs/user/ibmcloud/existing-cos-instance.md
- pkg/asset/installconfig/powervs/platform.go
- pkg/destroy/powervs/cloud-object-storage.go
- pkg/clusterapi/system.go
- pkg/types/powervs/metadata.go
- pkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.go
- pkg/asset/installconfig/powervs/mock/powervsclient_generated.go
- data/data/_configs.yaml
- pkg/asset/installconfig/ibmcloud/client.go
- pkg/destroy/powervs/powervs.go
- pkg/asset/installconfig/powervs/client.go
- pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go
- pkg/asset/installconfig/powervs/staging.go
taliandre49
force-pushed
the
staging-support-endpoints
branch
from
July 27, 2026 18:20
35a305c to
174d340
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/asset/manifests/infrastructure.go`:
- Around line 329-337: Update the endpoint handling around the service-name
normalization block so TransitGateway overrides are retained in Infrastructure
status instead of being discarded. Preserve the existing case normalization for
POWER, and ensure the CAPI configuration path maps the retained TransitGateway
value to the expected “transitgateway” endpoint representation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: cc991e72-cba3-4091-b737-4b4b523dc49b
⛔ Files ignored due to path filters (16)
cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/clients/instance/ibm-pi-image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/session.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/ibmpisession/utils.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_delete_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_cloud_connections/pcloud_cloudconnections_get_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_events/pcloud_events_getquery_parameters.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/github.com/IBM-Cloud/power-go-client/power/client/p_cloud_images/p_cloud_images_client.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_cluster.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_image.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/cloud/scope/powervs_machine.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/controllers/ibmpowervsimage_controller.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/authenticator/authenticator.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/cos/service.gois excluded by!**/vendor/**cluster-api/providers/ibmcloud/vendor/sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/cloud/services/resourcecontroller/service.gois excluded by!**/vendor/**data/data/install.openshift.io_installconfigs.yamlis excluded by!data/data/install.openshift.io_installconfigs.yamlvendor/github.com/openshift/api/config/v1/types.gois excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (33)
.gitignorecmd/openshift-install/command/log.gocmd/openshift-install/main.godata/data/_configs.yamldata/data/_installationconfigs.yamldata/data/cluster-api/ibmcloud-infrastructure-components.yamldocs/user/ibmcloud/existing-cos-instance.mdpkg/asset/cluster/ibmcloud/ibmcloud.gopkg/asset/cluster/powervs/powervs.gopkg/asset/installconfig/ibmcloud/client.gopkg/asset/installconfig/ibmcloud/metadata.gopkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.gopkg/asset/installconfig/ibmcloud/validation.gopkg/asset/installconfig/platformcredscheck.gopkg/asset/installconfig/powervs/client.gopkg/asset/installconfig/powervs/mock/powervsclient_generated.gopkg/asset/installconfig/powervs/platform.gopkg/asset/installconfig/powervs/session.gopkg/asset/installconfig/powervs/staging.gopkg/asset/manifests/infrastructure.gopkg/asset/manifests/powervs/cluster.gopkg/asset/releaseimage/default.gopkg/clusterapi/system.gopkg/destroy/powervs/cloud-object-storage.gopkg/destroy/powervs/powervs.gopkg/destroy/powervs/serviceinstance.gopkg/infrastructure/ibmcloud/clusterapi/clusterapi.gopkg/infrastructure/powervs/clusterapi/powervs.gopkg/types/ibmcloud/metadata.gopkg/types/ibmcloud/metadata_test.gopkg/types/ibmcloud/platform.gopkg/types/powervs/metadata.gopkg/types/powervs/platform.go
🚧 Files skipped from review as they are similar to previous changes (30)
- pkg/asset/cluster/powervs/powervs.go
- .gitignore
- pkg/asset/releaseimage/default.go
- pkg/asset/installconfig/platformcredscheck.go
- pkg/asset/installconfig/powervs/platform.go
- pkg/asset/installconfig/powervs/mock/powervsclient_generated.go
- data/data/_installationconfigs.yaml
- pkg/types/powervs/metadata.go
- pkg/asset/installconfig/ibmcloud/mock/ibmcloudclient_generated.go
- pkg/asset/cluster/ibmcloud/ibmcloud.go
- pkg/types/ibmcloud/platform.go
- data/data/_configs.yaml
- pkg/clusterapi/system.go
- pkg/asset/installconfig/ibmcloud/validation.go
- pkg/destroy/powervs/serviceinstance.go
- pkg/asset/installconfig/powervs/session.go
- pkg/types/ibmcloud/metadata_test.go
- cmd/openshift-install/command/log.go
- pkg/asset/installconfig/ibmcloud/metadata.go
- pkg/infrastructure/powervs/clusterapi/powervs.go
- pkg/infrastructure/ibmcloud/clusterapi/clusterapi.go
- data/data/cluster-api/ibmcloud-infrastructure-components.yaml
- docs/user/ibmcloud/existing-cos-instance.md
- pkg/asset/manifests/powervs/cluster.go
- pkg/destroy/powervs/cloud-object-storage.go
- cmd/openshift-install/main.go
- pkg/asset/installconfig/ibmcloud/client.go
- pkg/destroy/powervs/powervs.go
- pkg/asset/installconfig/powervs/staging.go
- pkg/asset/installconfig/powervs/client.go
taliandre49
force-pushed
the
staging-support-endpoints
branch
from
July 27, 2026 18:38
174d340 to
496d25c
Compare
Contributor
Author
|
note that verify-vendor is failing as CAPI PR [https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/2837] and API PR [https://github.com/openshift/api/pull/2959] to be pushed and vendored into main in order to succeed |
taliandre49
force-pushed
the
staging-support-endpoints
branch
2 times, most recently
from
July 28, 2026 15:55
a65c3bb to
8d816c4
Compare
Contributor
Author
|
status: removed lingering local override redirects for the PRs mentioned above (correct approach is wait for the PRs to be merged and re-vendor). Addressing CodeRabbits feedback |
taliandre49
force-pushed
the
staging-support-endpoints
branch
3 times, most recently
from
July 28, 2026 19:18
ebef0bc to
42360a7
Compare
openshift-ci
Bot
added
the
needs-rebase
taliandre49
force-pushed
the
staging-support-endpoints
branch
from
July 29, 2026 23:20
17116d1 to
65c7319
Compare
openshift-ci
Bot
removed
the
needs-rebase
Contributor
|
@taliandre49: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…nfiguration Add support for deploying OpenShift on IBM Cloud PowerVS against the IBM Cloud staging environment, and allow specifying a pre-existing COS instance for image and ignition storage. Staging support: - Add IBMCLOUD_STAGING env var and --staging flag to switch all service endpoints (IAM, COS, CIS, DNS, VPC, RC, Transit Gateway, Power IaaS) to IBM Cloud staging URLs - Propagate serviceEndpoints from install-config into cluster infrastructure manifests so CAPI controllers use the correct endpoints - Add IngressStrategy and ImageRegistryStorage platform options to work around staging environment limitations - Add NetworkID field to allow specifying a pre-created PowerVS private network (required on staging where DHCP server creation fails) Existing COS instance support: - Add COSInstanceCRN field to PowerVS and IBMCloud platform types - Skip COS instance creation when a CRN is provided - Add destroy logic to clean up COS buckets on existing instances - Add user documentation for the existing COS instance feature Signed-off-by: Natalia Jordan <natalia.jordan@ibm.com>
Signed-off-by: Natalia Jordan <natalia.jordan@ibm.com>
Deduplicate the repeated "private" and "public" string literals used when determining subnet scope for AWS machines. Define subnetScopePrivate and subnetScopePublic constants in awsmachines.go and replace all occurrences across machines.go and clusterapi_machinesets.go. Fixes golint goconst warnings.
Update the vendored content for sigs.k8s.io/cluster-api-provider-ibmcloud to match the alpha pseudo-version declared in go.mod (v0.13.0-alpha.0.0.20260729144403-83818de8b90e). The previous vendor directory contained v0.13.1 content which diverged from go.mod, causing verify-vendor failures.
The lone '/' on the last line was a catch-all that would silently ignore root-level files. Remove it; all intended ignore patterns were already present on the lines above.
taliandre49
force-pushed
the
staging-support-endpoints
branch
from
July 30, 2026 06:14
1f7ed9f to
f6a3139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add staging environment support and existing COS instance configuration
Summary
Adds support for deploying OpenShift on IBM Cloud PowerVS against the IBM
Cloud staging environment, and allows specifying a pre-existing COS instance
for image and ignition storage.
Changes
Staging environment support (
IBMCLOUD_STAGINGenv var /--stagingflag)staging.gowith helpers that return staging vs production serviceendpoint URLs (IAM, COS, CIS, DNS Services, VPC, Resource Controller,
Transit Gateway, Power IaaS) based on the
IBMCLOUD_STAGINGenvironmentvariable
serviceEndpointsfrominstall-config.yamlinto the clusterinfrastructure manifests so CAPI controllers use the correct endpoints
IngressStrategy: NodePortandImageRegistryStorage: emptyDirplatform options to work around staging environment limitations
NetworkIDfield to allow specifying a pre-created PowerVS privatenetwork (required on staging where DHCP server creation fails)
Existing COS instance support
COSInstanceCRNfield to bothPowerVSandIBMCloudplatform typesexisting instance instead
GetResourceInstanceByCRNandSetCOSBucketPublicIAMPolicyclientmethods
Other
fmt.Sprintfarg count mismatch inpkg/types/ibmcloud/metadata_test.goTesting
Verified end-to-end cluster installation against IBM Cloud staging environment
(us-south/dal12)
Summary by CodeRabbit
--stagingflag with staging-aware IBM Cloud endpoint selection..gitignorefor additional generated artifacts.