Skip to content

Add PluginStore.copyFrom method#324

Draft
vojtechszocs wants to merge 1 commit into
openshift:mainfrom
vojtechszocs:store-copyFrom
Draft

Add PluginStore.copyFrom method#324
vojtechszocs wants to merge 1 commit into
openshift:mainfrom
vojtechszocs:store-copyFrom

Conversation

@vojtechszocs

Copy link
Copy Markdown
Contributor

This method can be used in unit tests to copy internal state of an existing PluginStore into a new PluginStore instance.

const testPluginStore = PluginStore.copyFrom(appStoreImpl);

@openshift-ci openshift-ci Bot requested review from florkbr and karelhala July 1, 2026 13:52
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.54%. Comparing base (317459d) to head (bac9472).

Files with missing lines Patch % Lines
packages/lib-core/src/runtime/PluginStore.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   30.70%   30.54%   -0.16%     
==========================================
  Files          75       75              
  Lines        1964     1974      +10     
  Branches      349      349              
==========================================
  Hits          603      603              
- Misses       1332     1342      +10     
  Partials       29       29              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vojtechszocs vojtechszocs marked this pull request as draft July 1, 2026 17:22
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants