Skip to content

[4.22] OCPBUGS-91947: maxOpenShiftVersion should be bumped to 5.0#572

Open
dobsonj wants to merge 2 commits into
openshift:release-4.22from
dobsonj:OCPBUGS-90151-4.22
Open

[4.22] OCPBUGS-91947: maxOpenShiftVersion should be bumped to 5.0#572
dobsonj wants to merge 2 commits into
openshift:release-4.22from
dobsonj:OCPBUGS-90151-4.22

Conversation

@dobsonj

@dobsonj dobsonj commented Jun 23, 2026

Copy link
Copy Markdown
Member

https://redhat.atlassian.net/browse/OCPBUGS-91947

This PR allows setting MAX_OCP_VERSION as an environment variable for releases where the default x.y+1 max version is incorrect and pins the release-4.22 branch MAX_OCP_VERSION to 5.0.

  • hack/update-metadata.sh: allow MAX_OCP_VERSION override
  • Makefile: pin MAX_OCP_VERSION to 5.0

/cc @openshift/storage

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-91947

This PR allows setting MAX_OCP_VERSION as an environment variable for releases where the default x.y+1 max version is incorrect and pins the release-4.22 branch MAX_OCP_VERSION to 5.0.

  • hack/update-metadata.sh: allow MAX_OCP_VERSION override
  • Makefile: pin MAX_OCP_VERSION to 5.0

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@dobsonj: This pull request references Jira Issue OCPBUGS-91947, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-90151 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://redhat.atlassian.net/browse/OCPBUGS-91947

This PR allows setting MAX_OCP_VERSION as an environment variable for releases where the default x.y+1 max version is incorrect and pins the release-4.22 branch MAX_OCP_VERSION to 5.0.

  • hack/update-metadata.sh: allow MAX_OCP_VERSION override
  • Makefile: pin MAX_OCP_VERSION to 5.0

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3b36f4f4-08d2-4899-9d4d-efaaeaebf640

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@dobsonj

dobsonj commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

/test aws-efs-operator-e2e
/test smb-operator-e2e

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/aws-efs-operator-e2e 893a5e7 link true /test aws-efs-operator-e2e
ci/prow/hypershift-e2e-aks 893a5e7 link false /test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants