NO-JIRA: Add ReadWriteOncePod support for Cinder CSI driver - #16870
NO-JIRA: Add ReadWriteOncePod support for Cinder CSI driver#16870Surote wants to merge 1 commit into
Conversation
The Cinder CSI driver supports the SINGLE_NODE_SINGLE_WRITER access mode, so ReadWriteOncePod is a valid access mode for both Filesystem and Block volumes provisioned by cinder.csi.openstack.org. Also remove the duplicate ReadWriteOncePod entry from the in-tree kubernetes.io/cinder mapping. The duplicate had no functional effect since getAccessModeForProvisioner dedupes the list, but the mapping was incorrect. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@Surote: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughChangesProvisioner access modes
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Surote The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Surote. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Analysis / Root cause:
The provisioner-to-access-mode mapping in
frontend/public/components/storage/shared.tsdid not listReadWriteOncePodfor the OpenStack Cinder CSI driver (cinder.csi.openstack.org), so the access mode was not offered in the console when creating a PVC or a StorageClass-backed volume with that provisioner. The Cinder CSI driver reports theSINGLE_NODE_SINGLE_WRITERcapability, which maps toReadWriteOncePod, so the mode is valid for bothFilesystemandBlockvolume modes.Separately, the in-tree
kubernetes.io/cinderentry listedReadWriteOncePodtwice in both of its volume mode arrays.Solution description:
cinder.csi.openstack.org: addedReadWriteOncePodto theFilesystemandBlockaccess mode lists.kubernetes.io/cinder: removed the duplicatedReadWriteOncePodentry from both lists. This had no functional effect, sincegetAccessModeForProvisionerde-duplicates the result with aSet, but the mapping itself was incorrect.No API, extension, or i18n changes.
ReadWriteOncePodis already part of theAccessModetype,initialAccessModes, andgetAccessModeOptions.Screenshots / screen recording:
Test setup:
An OpenShift cluster running on OpenStack with the Cinder CSI driver installed, providing a StorageClass whose provisioner is
cinder.csi.openstack.org.Test cases:
cinder.csi.openstack.org.Filesystem, create the PVC, and verify it binds and reportsReadWriteOncePod.Block.manila.csi.openstack.org), verify its access mode options are unchanged.Browser conformance:
Additional info:
Reference: Kubernetes access modes and the Cinder CSI driver capabilities.
Reviewers and assignees:
🤖 Generated with Claude Code
Summary by CodeRabbit
ReadWriteOncePodsupport for OpenStack Cinder CSI volumes.