Skip to content

NO-JIRA: owners: update - #1563

Open
Tal-or wants to merge 1 commit into
openshift:mainfrom
Tal-or:update_owners
Open

NO-JIRA: owners: update#1563
Tal-or wants to merge 1 commit into
openshift:mainfrom
Tal-or:update_owners

Conversation

@Tal-or

@Tal-or Tal-or commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

remove unauthorized gh users

Summary by CodeRabbit

  • Chores
    • Updated component ownership configuration by removing an individual reviewer entry.

remove unauthorized gh users

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Walkthrough

The OWNERS configuration removes rbaturov from the approvers/reviewers list for the Node Tuning Operator component.

Changes

OWNERS update

Layer / File(s) Summary
Remove approver entry
OWNERS
The approvers/reviewers list no longer contains rbaturov.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the OWNERS change, but it is too generic to convey the specific removal of unauthorized users. Rename it to describe the concrete change, e.g. remove unauthorized approver/reviewer from OWNERS for Node Tuning Operator.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only OWNERS changed; no test files or Ginkgo titles were modified, so the stability check is not applicable.
Test Structure And Quality ✅ Passed Only OWNERS changed; no Ginkgo test code or test behavior was modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed This PR only removes one reviewer from OWNERS; no Ginkgo/e2e tests or OpenShift API usages were added or changed.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only deletes one OWNERS entry; no e2e/Ginkgo tests were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only OWNERS changed; no deployment manifests, operator code, or controllers were modified, so no scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only removes a reviewer from OWNERS; no binary or process-level stdout code changed, so the OTE stdout contract isn't affected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only OWNERS changed; no Ginkgo e2e tests or network-dependent code were added or modified.
No-Weak-Crypto ✅ Passed Only OWNERS changed; no crypto code, weak ciphers, or secret comparisons were added or modified.
Container-Privileges ✅ Passed HEAD only changes OWNERS; no container/K8s manifests or privilege settings were modified.
No-Sensitive-Data-In-Logs ✅ Passed PR only edits OWNERS membership; no code or log statements changed, so no sensitive data exposure was introduced.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from ffromani and swatisehgal July 16, 2026 08:48
@ffromani

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@Tal-or

Tal-or commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@Tal-or

Tal-or commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@Tal-or Tal-or changed the title owners: update NO-JIRA: owners: update Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Tal-or: This pull request explicitly references no jira issue.

Details

In response to this:

remove unauthorized gh users

Summary by CodeRabbit

  • Chores
  • Updated component ownership configuration by removing an individual reviewer entry.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 22, 2026
@Tal-or

Tal-or commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@Tal-or: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tal-or

Tal-or commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

/verified by @Tal-or

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 22, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@Tal-or: This PR has been marked as verified by @Tal-or.

Details

In response to this:

/verified by @Tal-or

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swatisehgal swatisehgal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD a9d25d5 and 2 for PR HEAD 65d93ad in total

@Tal-or

Tal-or commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@Tal-or: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-pao 65d93ad link true /test e2e-hypershift-pao
ci/prow/e2e-gcp-pao 65d93ad link true /test e2e-gcp-pao

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Tal-or

Tal-or commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants