Revert "TRT-2701: Revert "SPLAT-2793: Promoted VSphereMultiVCenterDay2 feature gate to TP""

[vr4manta]

Reverts #2885

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@vr4manta: This pull request references TRT-2701 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Reverts #2885

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR promotes the VSphereMultiVCenterDay2 feature gate to TechPreview channel support, expanding it beyond the existing DevPreview availability. The core feature definition is updated in features.go, and the change is documented in the reference table. TechPreviewNoUpgrade manifests for both HyperShift and SelfManagedHA profiles are updated to enable the gate. Additionally, CRD validation schemas in Infrastructure and ControllerConfig are strengthened with new admission rules that prevent concurrent vCenter additions and removals, and enforce that once the vCenters field is set, it cannot be removed.

Possibly related PRs

• openshift/api#2879: Related Infrastructure and ControllerConfig CRD validation updates for vCenter multi-tenancy constraints
• openshift/api#2885: Concurrent change affecting VSphereMultiVCenterDay2 TechPreview enablement status in feature gate definitions

Suggested reviewers

• everettraven
• JoelSpeed
• petr-muller

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: reverting a previous revert of the VSphereMultiVCenterDay2 feature gate promotion to TechPreview, which aligns with all file modifications in the changeset.
Description check	✅ Passed	The description directly references the PR being reverted (#2885), which is related to the changeset's purpose, though it is minimal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names in tests/generator.go are generated from static CRD metadata and test YAML specs without any dynamic values like timestamps, UUIDs, or generated identifiers.
Test Structure And Quality	✅ Passed	No Ginkgo test files present in this PR. Only feature gate configuration, Go code, documentation, and YAML manifests are modified. Test structure check not applicable.
Microshift Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; it only modifies feature gates, CRD validation rules, and documentation, which are not subject to the MicroShift compatibility check.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. The changes are limited to feature gate definitions, documentation, and Kubernetes CRD validation rules - no e2e test code is added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR contains no deployment manifests, pod specs, or scheduling constraints. Changes are feature gate enablement and vSphere configuration validation only.
Ote Binary Stdout Contract	✅ Passed	PR modifies only feature gate declarations and YAML schema files; no process-level code (main, init, TestMain, BeforeSuite, etc.) with potential stdout violations was changed.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR contains no new Ginkgo e2e tests - it only modifies feature gate configuration, CRD validation rules, and documentation files. IPv6/disconnected network check is not applicable.
No-Weak-Crypto	✅ Passed	No weak cryptographic patterns, custom crypto, or insecure comparisons detected in feature gate and validation rule changes.
Container-Privileges	✅ Passed	OpenShift API repository with feature gate and CRD schema changes. No container workload manifests or privileged container configurations found in the PR modifications.
No-Sensitive-Data-In-Logs	✅ Passed	No logging that exposes sensitive data found. Changes only include feature gate configuration, CRD validation rules, and YAML reordering with no logging calls.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/hold
Do not merge yet. Using this to test with installer PR fix.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml`:
- Around line 1376-1383: Update the Go field comment for the vcenters field to
document the new validation that forbids mixing additions and removals in a
single update (i.e., updates may add vCenters or remove vCenters but not both at
once), ensure the kubebuilder validation markers for these two rules are
described in that comment (per coding guidelines), then regenerate the CRD so
the YAML (controllerconfigs-TechPreviewNoUpgrade CRD) includes the updated field
description matching the admission rules. Make sure you edit the comment on the
vcenters field in the corresponding Go struct (the VCenters/vcenters field) and
run the CRD generation step.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2f463a9f-569f-4673-9657-212ff8097f81

📥 Commits

Reviewing files that changed from the base of the PR and between 6dc0643 and 1bf28d7.

⛔ Files ignored due to path filters (3)

• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• openapi/openapi.json is excluded by !openapi/**

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/crds/0000_10_config-operator_01_infrastructures-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Document the new mixed add/remove restriction in the API comment.

These rules now reject a single update that both adds and removes vcenters, but the field description still says TechPreview clusters can “add and remove vCenters” without spelling out that those operations must happen in separate updates. Please update the source Go comment for vcenters and regenerate this CRD so the schema docs match the new admission behavior.

As per coding guidelines, "All kubebuilder validation markers must be documented in the field's comment" and the review must fail on "Any validation marker without corresponding documentation."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@payload-manifests/crds/0000_80_machine-config_01_controllerconfigs-TechPreviewNoUpgrade.crd.yaml`
around lines 1376 - 1383, Update the Go field comment for the vcenters field to
document the new validation that forbids mixing additions and removals in a
single update (i.e., updates may add vCenters or remove vCenters but not both at
once), ensure the kubebuilder validation markers for these two rules are
described in that comment (per coding guidelines), then regenerate the CRD so
the YAML (controllerconfigs-TechPreviewNoUpgrade CRD) includes the updated field
description matching the admission rules. Make sure you edit the comment on the
vcenters field in the corresponding Go struct (the VCenters/vcenters field) and
run the CRD generation step.

Source: Coding guidelines

[openshift-ci]

@vr4manta: This PR was included in a payload test run from openshift/installer#10614
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dd5354a0-64ff-11f1-9551-7241ecef6134-0