HPCASE-362: Promote TLSAdherence feature gate to GA

[joelanford]

Summary

Promotes the TLSAdherence feature gate to GA by enabling it in the Default and OKD feature sets (in addition to the existing TechPreviewNoUpgrade and DevPreviewNoUpgrade).

This enables the tlsAdherence field on the apiserver.config.openshift.io/v1 APIServer resource for all clusters, allowing administrators to control how strictly components honor the centralized TLS security profile.

References

• Enhancement: Add enhancement spec for centralized TLS configuration and enforcement enhancements#1910
• Strategy: https://issues.redhat.com/browse/OCPSTRAT-2611
• Epic: https://issues.redhat.com/browse/HPCASE-362

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @joelanford! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR promotes the TLSAdherence feature gate from a disabled/tech-preview state to enabled across default and OKD deployment profiles. The feature gate definition in features.go is updated to include inDefault() and inOKD() enablement conditions. The features.md documentation table is reordered to reflect the change, and four deployment manifest files (Hypershift Default/OKD and SelfManagedHA Default/OKD) are updated to move TLSAdherence from their disabled feature lists to enabled feature lists.

Suggested reviewers

• everettraven
• JoelSpeed

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description is directly related to the changeset, providing a clear summary of promoting TLSAdherence to GA with relevant references and context about the implications of the change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies feature gate configuration files and documentation (features.md, features.go, YAML manifests) with no Ginkgo tests, making this check not applicable.
Test Structure And Quality	✅ Passed	Tests demonstrate quality: proper BeforeEach/AfterEach cleanup, defined 5s timeouts, meaningful assertion messages, single-responsibility via DescribeTable, consistent envtest patterns.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. Changes are limited to feature gate documentation and configuration (features.md, features.go, and YAML manifests). The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests. All modified files (features.md, features.go, YAML manifests) are configuration files with no test code.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies feature gate configuration in openshift/api. No deployment manifests, operator code, or controllers are modified, so scheduling constraints check is not applicable.
Ote Binary Stdout Contract	✅ Passed	PR modifies feature gate config, manifests, and test suite. Process-level logging uses GinkgoWriter, not stdout. No OTE Binary Stdout Contract violations.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR adds no new Ginkgo e2e tests. Changes are limited to feature gate declarations (features.go), documentation (features.md), and YAML manifests—not test files.
No-Weak-Crypto	✅ Passed	No weak cryptographic algorithms, custom crypto implementations, or insecure secret comparisons found in PR. Changes are feature gate configuration only.
Container-Privileges	✅ Passed	No container privilege escalation settings found. Files contain only feature gate definitions and configurations without any container, pod, or deployment specifications.
No-Sensitive-Data-In-Logs	✅ Passed	No logging statements or sensitive data (passwords, tokens, API keys, PII, session IDs, hostnames, customer data) found in the PR changes to features.md, features/features.go, or YAML manifest files.
Title check	✅ Passed	The title 'Promote TLSAdherence feature gate to GA' clearly and concisely summarizes the main objective of the pull request, which is to promote the TLSAdherence feature gate to general availability across multiple feature sets.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelanford]

This is speculative to see what gating criteria need to be added to https://redhat.atlassian.net/browse/HPCASE-362

[joelanford]

/test ?

[openshift-ci]

@joelanford: The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-hypershift-conformance

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial-1of2

/test e2e-aws-serial-2of2

/test e2e-aws-serial-techpreview-1of2

/test e2e-aws-serial-techpreview-2of2

/test e2e-azure

/test e2e-gcp

/test e2e-upgrade

/test e2e-upgrade-out-of-change

/test images

/test integration

/test lint

/test minor-e2e-upgrade-minor

/test minor-images

/test okd-scos-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-crdify

/test verify-deps

/test verify-feature-promotion

/test verify-hypershift-integration

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build

pull-ci-openshift-api-master-images

pull-ci-openshift-api-master-integration

pull-ci-openshift-api-master-lint

pull-ci-openshift-api-master-minor-images

pull-ci-openshift-api-master-okd-scos-images

pull-ci-openshift-api-master-unit

pull-ci-openshift-api-master-verify

pull-ci-openshift-api-master-verify-client-go

pull-ci-openshift-api-master-verify-crd-schema

pull-ci-openshift-api-master-verify-crdify

pull-ci-openshift-api-master-verify-deps

pull-ci-openshift-api-master-verify-feature-promotion

pull-ci-openshift-api-master-verify-hypershift-integration

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@joelanford: This pull request references HPCASE-362 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Promotes the TLSAdherence feature gate to GA by enabling it in the Default and OKD feature sets (in addition to the existing TechPreviewNoUpgrade and DevPreviewNoUpgrade).

This enables the tlsAdherence field on the apiserver.config.openshift.io/v1 APIServer resource for all clusters, allowing administrators to control how strictly components honor the centralized TLS security profile.

References

• Enhancement: Add enhancement spec for centralized TLS configuration and enforcement enhancements#1910
• Strategy: https://issues.redhat.com/browse/OCPSTRAT-2611
• Epic: https://issues.redhat.com/browse/HPCASE-362

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@joelanford: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	9fce402	link	true	/test verify-feature-promotion
ci/prow/verify	9fce402	link	true	/test verify
ci/prow/integration	9fce402	link	true	/test integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.