Skip to content

HYPERFLEET-1090 - refactor: rename WIFConfig to WifConfig (PascalCase)#5

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
sherine-k:1090-WIFConfig
Jun 9, 2026
Merged

HYPERFLEET-1090 - refactor: rename WIFConfig to WifConfig (PascalCase)#5
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
sherine-k:1090-WIFConfig

Conversation

@sherine-k

Copy link
Copy Markdown
Contributor

Adopt PascalCase for the WifConfig resource kind to stay consistent with other HyperFleet resource naming (e.g., NodePool). (see hyperfleet-api #198)

  • Rename all TypeSpec models, consts, and aliases from WIFConfig to WifConfig
  • Update service interface, operation IDs, and tags to use WifConfig casing
  • Regenerate openapi.yaml and swagger.yaml with new schema names
  • Bump version to 1.0.21 and add CHANGELOG entry

Summary

  • HYPERFLEET-1090

Test Plan

  • Unit tests added/updated
  • make test-all passes
  • make lint passes
  • Helm chart changes validated with make test-helm (if applicable)
  • Deployed to a development cluster and verified (if Helm/config changes)
  • E2E tests passed (if cross-component or major changes)

@openshift-ci openshift-ci Bot requested review from Mischulee and crizzo71 June 4, 2026 15:38
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ff5c1677-5220-42d4-a32b-51fcf64f0445

📥 Commits

Reviewing files that changed from the base of the PR and between ceadd4e and ad2b869.

📒 Files selected for processing (9)
  • CHANGELOG.md
  • main.tsp
  • models/wifconfig/example_patch.tsp
  • models/wifconfig/example_post.tsp
  • models/wifconfig/example_wifconfig.tsp
  • models/wifconfig/model.tsp
  • schemas/template/openapi.yaml
  • schemas/template/swagger.yaml
  • services/wifconfigs.tsp

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Bumped API version to 1.0.22
    • Standardized naming conventions for the WifConfig resource across API definitions to ensure consistency in casing and references

Walkthrough

This PR standardizes the WifConfig resource naming convention across the API spec. The version is bumped from 1.0.21 to 1.0.22. All occurrences of WIFConfig are renamed to WifConfig in TypeSpec model definitions, service operation identifiers, and generated OpenAPI and Swagger schemas. The change includes model aliases, request/response types, example payloads, and all operation IDs (list, create, get, patch, delete).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main change: renaming WIFConfig to WifConfig (PascalCase) for consistency.
Description check ✅ Passed The PR description is well-related to the changeset, explaining the refactoring rationale, listing specific changes across TypeSpec, service definitions, and generated schemas.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed Repository contains zero Go files. All 9 modified files (TypeSpec models, YAML schemas, markdown) are configuration/spec files with no logging statements. Check is not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Adopt PascalCase for the WifConfig resource kind to stay consistent with
other HyperFleet resource naming (e.g., NodePool).

- Rename all TypeSpec models, consts, and aliases from WIFConfig to WifConfig
- Update service interface, operation IDs, and tags to use WifConfig casing
- Regenerate openapi.yaml and swagger.yaml with new schema names
- Bump version to 1.0.21 and add CHANGELOG entry

@ciaranRoche ciaranRoche left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jun 9, 2026
@sherine-k

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@openshift-merge-bot openshift-merge-bot Bot merged commit 7ce8014 into openshift-hyperfleet:main Jun 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants