Skip to content

Update google.golang.org/genproto digest to 7ab31c2#189

Open
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/google.golang.org-genproto-digest
Open

Update google.golang.org/genproto digest to 7ab31c2#189
red-hat-konflux-kflux-prd-rh02[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/google.golang.org-genproto-digest

Conversation

@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
google.golang.org/genproto indirect digest 0a33c5d7ab31c2

Configuration

📅 Schedule: Branch creation - "on monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Signed-off-by: red-hat-konflux-kflux-prd-rh02 <190377777+red-hat-konflux-kflux-prd-rh02[bot]@users.noreply.github.com>
@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 7 additional dependencies were updated

Details:

Package Change
golang.org/x/text v0.35.0 -> v0.37.0
golang.org/x/crypto v0.49.0 -> v0.51.0
golang.org/x/net v0.52.0 -> v0.54.0
golang.org/x/sys v0.42.0 -> v0.44.0
golang.org/x/term v0.41.0 -> v0.43.0
google.golang.org/genproto/googleapis/rpc v0.0.0-20260523011958-0a33c5d7ca68 -> v0.0.0-20260526163538-3dc84a4a5aaa
google.golang.org/grpc v1.80.0 -> v1.81.1

@openshift-ci openshift-ci Bot requested review from crizzo71 and rh-amarin June 15, 2026 16:06
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jsell-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hi @red-hat-konflux-kflux-prd-rh02[bot]. Thanks for your PR.

I'm waiting for a openshift-hyperfleet member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to current versions for improved stability and security.

Walkthrough

go.mod receives version bumps across two require blocks. The direct dependency golang.org/x/text moves from v0.35.0 to v0.37.0. Seven indirect entries are advanced: golang.org/x/crypto, golang.org/x/net, golang.org/x/sys, golang.org/x/term, google.golang.org/genproto, google.golang.org/genproto/googleapis/api, google.golang.org/genproto/googleapis/rpc, and google.golang.org/grpc. No exported APIs, logic, or configuration outside go.mod are changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


Supply chain surface — verify before merge:

  • golang.org/x/crypto is a direct attack surface for TLS/SSH operations (CWE-295, CWE-326). Confirm the exact version resolves no active CVEs before merging into this Adapter's gRPC transport path.
  • google.golang.org/grpc version should be cross-referenced against the gRPC CVE tracker — past issues include CWE-400 (resource exhaustion) and CWE-770 in stream handling.
  • golang.org/x/net carries HTTP/2 history (CVE-2023-44487, CWE-400). Confirm the new revision is post-patch.
  • go.sum is not shown in this diff. Verify it was regenerated atomically with these go.mod changes; a detached go.sum update is a CWE-494 risk (Download of Code Without Integrity Check).
  • Confirm go mod verify passes in CI before the Adapter image is built. A missing or bypassed verification step in the pipeline is a supply chain attack vector.
🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title specifically references the main change: updating google.golang.org/genproto to digest 7ab31c2, which directly matches the primary update in the changeset.
Description check ✅ Passed The description details the google.golang.org/genproto digest update from 0a33c5d to 7ab31c2, matching the changeset and indicating this is an automated dependency upgrade via MintMaker/Renovate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed No log statements expose secrets, tokens, passwords, or credentials. Config is redacted via Redacted(), token values are never logged, WithFields calls only log non-sensitive data like sourceID and...
No Hardcoded Secrets ✅ Passed No hardcoded secrets found. PR only adds .bingo tool management files with version hashes and environment variables. No API keys, tokens, passwords, private keys, URLs with credentials, or suspicio...
No Weak Cryptography ✅ Passed No banned cryptographic primitives (MD5, DES, RC4, SHA1 for security), ECB mode, custom crypto implementations, or non-constant-time secret comparisons detected. Codebase uses only secure crypto: T...
No Injection Vectors ✅ Passed PR updates go.mod dependencies only. Code review found no CWE-89 (SQL injection), CWE-79 (template.HTML), or CWE-502 (unsafe yaml.Unmarshal) injection vectors. CWE-78 (exec.Command) used only in te...
No Privileged Containers ✅ Passed PR modifies only go.mod (dependency versions); does not touch K8s manifests, Helm templates, or Dockerfiles. Check is inapplicable.
No Pii Or Sensitive Data In Logs ✅ Passed PR introduces no logging statements exposing PII/sensitive data. Debug-level payload logging disabled by default (Level: info). Config logging uses Redacted() method redacting TLS certs/keys/files....

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/main/google.golang.org-genproto-digest
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch konflux/mintmaker/main/google.golang.org-genproto-digest

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 29: The golang.org/x/text dependency has been upgraded from v0.35.0 to
v0.37.0, which can introduce changes in title-casing behavior. Locate the
cases.Title(language.English) call in the template helpers and verify that the
title-casing output remains correct and produces the expected user-facing
results with the new version. Test any templated titles that rely on this
function to ensure the casing behavior has not changed in a way that breaks
functionality or user experience.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5886e2db-6a9c-4923-86fb-8809a5dcbaae

📥 Commits

Reviewing files that changed from the base of the PR and between 7f49e34 and e207e74.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum, !**/go.sum
📒 Files selected for processing (1)
  • go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

Comment thread go.mod
go.opentelemetry.io/otel/sdk v1.43.0
go.opentelemetry.io/otel/trace v1.43.0
golang.org/x/text v0.35.0
golang.org/x/text v0.37.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Verify golang.org/x/text v0.37.0 compatibility with template helpers.

golang.org/x/text v0.35.0 → v0.37.0 affects the cases.Title(language.English) call in pkg/utils/template.go:31-33. Minor version bumps can change title-casing behavior. Verify no user-facing output (e.g., templated titles) is broken by this change.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@go.mod` at line 29, The golang.org/x/text dependency has been upgraded from
v0.35.0 to v0.37.0, which can introduce changes in title-casing behavior. Locate
the cases.Title(language.English) call in the template helpers and verify that
the title-casing output remains correct and produces the expected user-facing
results with the new version. Test any templated titles that rely on this
function to ensure the casing behavior has not changed in a way that breaks
functionality or user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants