Preserve plugin-managed indices during integration test cleanup#5630
Open
ahkcs wants to merge 1 commit into
Open
Preserve plugin-managed indices during integration test cleanup#5630ahkcs wants to merge 1 commit into
ahkcs wants to merge 1 commit into
Conversation
Signed-off-by: Kai Huang <ahkcs@amazon.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents per-class integration test cleanup from deleting plugin-managed indices.
In release integration test run 11379, the secured SQL suite took 4h44m versus 41m without security. The secured cluster log shows cleanup deleting and forcing recreation of
security-auditlog-*358 times, once per test-class cleanup, along with 575 audit-indexing errors. Many of those errors were generated by attempted deletion of protected ML and geospatial indices.This change extends the existing system-index filter to preserve the observed plugin-managed prefixes. Ordinary test indices, including unrelated hidden test indices, remain eligible for cleanup.
A representative secured A/B run of
SQLCursorPermissionsITshowed:main: audit index created, deleted by cleanup, then recreated.The next distribution integration run will provide the full-suite runtime measurement.
Related Issues
Follow-up to #5620
Testing
./gradlew :integ-test:spotlessJavaCheck :integ-test:compileTestJava --no-daemon./gradlew :integ-test:integTest --tests "org.opensearch.sql.legacy.OpenSearchSQLRestTestCaseIT" -DignorePrometheus=true --no-daemon./gradlew :integ-test:integTestWithSecurity --tests "org.opensearch.sql.security.SQLCursorPermissionsIT" --no-daemonCheck List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.