HamcrestMatcherToJUnit5: support Kotlin sources#1058
Merged
Conversation
timtebeek
marked this pull request as draft
July 24, 2026 10:24
timtebeek
commented
Jul 24, 2026
rewrite#8324 (KotlinTemplate: attribute members selected on substituted placeholders) attributes the synthesized member calls, which cascades to the enclosing assertion, so the manual attributeTypes pass is no longer needed.
rewrite#8324 types members-on-placeholders and their enclosing calls, but JUnit's assertX(condition, String) vs assertX(condition, Supplier) overloads stay ambiguous when the reason is a substituted placeholder, leaving the call untyped so the static import is dropped. Attribute just that enclosing call.
timtebeek
marked this pull request as ready for review
July 25, 2026 07:04
timtebeek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HamcrestMatcherToJUnit5threw "No JavaSourceFile parent found" on Kotlin test sources because it always usedJavaTemplate; it now branches onK.CompilationUnitand applies aKotlinTemplate(viaKotlinParser) for Kotlin sources. It uses a Kotlin-specific template variant where the Java form is invalid Kotlin (Collection.size()→.size) and fixes a latent unbalanced-paren typo in thecontainsStringtemplate that only the Kotlin parser rejected. Type attribution of the generated assertions relies on the upstream fix openrewrite/rewrite#8324 (KotlinTemplate attributes members selected on substituted placeholders), so it needs a rewrite snapshot ≥ 8.88.0 build 59. The only remaining manual attribution is the enclosingassertX(condition, reason)call, which Kotlin leaves untyped because JUnit's(…, String)and(…, Supplier)overloads are ambiguous when the reason is a substituted placeholder. Adds Kotlin tests covering equalTo, not, greaterThan, containsString, nullValue, collections, and reason arguments.