Track the Maven UpgradeTransitiveDependencyVersion accumulator type change - #193
Merged
Conversation
…hange rewrite-maven's UpgradeTransitiveDependencyVersion now scans into its own Accumulator rather than AddManagedDependency.Scanned. Retype the wrapper's mavenAccumulator field to match so it compiles against the new rewrite-maven API (see openrewrite/rewrite#8342).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That PR changes
rewrite-maven'sUpgradeTransitiveDependencyVersionto scan into its ownAccumulatorinstead ofAddManagedDependency.Scanned(so it can update an existing managed entry in place). This wrapper'sAccumulator.mavenAccumulatorfield referenced the old type, so it must be retyped to match or the wrapper fails to compile against the new API.The delegating scanner/visitor pass the accumulator straight through, so this is a one-line type change.