Fix AddTimeUnitArgument crash on arithmetic argument expressions

[timtebeek]

Problem

AddTimeUnitArgument (invoked by UpgradeApacheHttpClient_5_TimeUnit) throws IllegalArgumentException: Could not parse as Java when the timeout argument is a binary/arithmetic expression such as 60 * 1000:

RequestConfig.custom()
    .setConnectionRequestTimeout(60 * 1000) // arithmetic expression
    .build();

Plain integer literals and variables were handled fine — only binary expressions crashed.

Root cause

The recipe rebuilt the whole argument list through a contextSensitive() JavaTemplate of the form #{any()}, TimeUnit.#{} with replaceArguments(). Re-parsing the original argument inside the synthetic template stub placed the __TEMPLATE_STOP__ boundary incorrectly for binary expressions, producing unparseable Java.

Fix

Append the TimeUnit argument to the existing argument LST instead of re-templating all arguments via #{any()}. The original expression is never re-parsed. The invocation's method type is extended with the new TimeUnit parameter so the recipe stays idempotent (the matcher no longer matches after the argument is added).

Tests

Added arithmeticTimeoutArgument reproducing the reported crash; all existing AddTimeUnitArgumentTest and httpclient5 tests still pass.

• Fixes AddTimeUnitArgument fails with "Could not parse as Java" when the timeout argument is an arithmetic expression (e.g. 60 * 1000) #138