Allow connection deletion when connection is invalid#2353
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts app-connection deletion to work even when a stored connection can’t be decrypted/refreshed, by fetching only the minimal DB metadata needed for telemetry before deleting.
Changes:
- Update DELETE
/app-connections/:idto fetch connection metadata (instead of fully decrypting the connection) before deletion. - Add
appConnectionService.getMetadataOrThrowto retrieve{ projectId, authProviderKey }without decrypt/refresh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/server/api/src/app/app-connection/app-connection.controller.ts | Uses getMetadataOrThrow for delete flow to avoid failing deletion on invalid connections while still emitting telemetry. |
| packages/server/api/src/app/app-connection/app-connection-service/app-connection-service.ts | Adds getMetadataOrThrow to fetch minimal connection fields without decryption/refresh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add tests covering: - Happy path returning id, projectId, and authProviderKey - ENTITY_NOT_FOUND error when connection does not exist - Regression test proving metadata retrieval works even when decryption would fail Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
ravikiranvm
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-4537