Add method reference to FuncOp

[mabbay]

Allow user to attach a MethodRef to a FuncOp.
Compiler tests are failing because of these changes, instead of updating the tests, we remove the source attribute from the javac model before testing.
Attaching MethodRef to FuncOp will allow us to access the original j.l.r.Method from which we extracted a FuncOp -JDK-8376824

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/992/head:pull/992
$ git checkout pull/992

Update a local copy of the PR:
$ git checkout pull/992
$ git pull https://git.openjdk.org/babylon.git pull/992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 992

View PR using the GUI difftool:
$ git pr show -t 992

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/992.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mabbay! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mabbay This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Add method reference to FuncOp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the code-reflection branch:

• 8e278d7: Align Op.ofElement with ReflectMethods::visitMethodDef

Please see this link for an up-to-date comparison between the source branch of this pull request and the code-reflection branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

[openjdk]

@mabbay this pull request can not be integrated into code-reflection due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout funcop-mref
git fetch https://git.openjdk.org/babylon.git code-reflection
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge code-reflection"
git push

[mabbay]

/template append

[openjdk]

@mabbay The pull request template has been appended to the pull request body

[bridgekeeper]

@mabbay This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mlbridge]

Webrevs

• 00: Full (e558680e)

[PaulSandoz]

Check for canonicalization of models in runtime tests.

[PaulSandoz]

The method name seems to describe the inversion of its implementation. Perhaps change to:

private boolean isSyntheticSourceRef() {
    return source.refType().equals(JavaType.VOID);
}

[PaulSandoz]

Change to:

/**
 * {@return the source reference to the method this operation models, otherwise an empty optional if the reference is unavailable.}
 */
public Optional<MethodRef> sourceRef() {
    return isSyntheticSourceRef() ? Optional.empty() : Optional.of(source);
}

[PaulSandoz]

Make note this is a work around to avoid updating the tests, which we will do later.