Skip to content

feat: remove built-in Discussion XBlock implementation (slash-n-burn #37819)#38749

Open
irfanuddinahmad wants to merge 3 commits into
masterfrom
irfanuddinahmad/slash-and-burn-discussion-block
Open

feat: remove built-in Discussion XBlock implementation (slash-n-burn #37819)#38749
irfanuddinahmad wants to merge 3 commits into
masterfrom
irfanuddinahmad/slash-and-burn-discussion-block

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the built-in Discussion XBlock from xmodule/ as part of the Slash-n-Burn Built-In XBlocks epic (#37819). The extracted version in xblocks-contrib has been the active implementation since USE_EXTRACTED_DISCUSSION_BLOCK was set to True.

Deleted:

  • xmodule/discussion_block.py — built-in _BuiltInDiscussionXBlock and shim
  • xmodule/tests/test_discussion.py — built-in unit tests
  • xmodule/js/src/discussion/display.js — block JS

Modified:

  • openedx/envs/common.py — removed USE_EXTRACTED_DISCUSSION_BLOCK toggle
  • pyproject.toml — removed conflicting discussion entrypoint
  • lms/djangoapps/courseware/management/commands/dump_course_structure.py — import DiscussionXBlock from xblocks_contrib.discussion
  • openedx/core/djangoapps/discussions/utils.py — import DiscussionXBlock from xblocks_contrib.discussion
  • lms/djangoapps/courseware/tests/test_discussion_xblock.py — import DiscussionXBlock from xblocks_contrib.discussion

Note: lms/djangoapps/discussion/ (the forum service Django app) is NOT in scope for this removal.

Test plan

  • Run pytest lms/djangoapps/courseware/tests/test_discussion_xblock.py — all tests pass
  • Verify Discussion XBlocks in a live course still render (served by xblocks-contrib)
  • Run the dump_course_structure management command on a course with discussion blocks — no import errors

🤖 Generated with Claude Code

Closes openedx/public-engineering#538

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 11, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-discussion-block branch from 291afe6 to 7649131 Compare June 11, 2026 12:52
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-discussion-block branch from a21972c to 12185a2 Compare June 12, 2026 11:53
Irfan Ahmad and others added 3 commits June 12, 2026 21:55
…37819)

Removes xmodule/discussion_block.py, its JS assets, built-in unit tests,
the USE_EXTRACTED_DISCUSSION_BLOCK toggle, and the conflicting 'discussion'
entrypoint in pyproject.toml now that the extracted version in xblocks-contrib
is the only implementation. Updates production imports in dump_course_structure
and discussions/utils to import DiscussionXBlock from xblocks_contrib.discussion.

Note: lms/djangoapps/discussion/ Django app is NOT in scope for this removal.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-discussion-block branch from 12185a2 to ab31c37 Compare June 12, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

[Refactor] Slash-n-Burn Discussion BuiltIn XBlock

3 participants