feat: remove built-in LTI XBlock implementation (slash-n-burn #37819)#38747
feat: remove built-in LTI XBlock implementation (slash-n-burn #37819)#38747irfanuddinahmad wants to merge 3 commits into
Conversation
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
7eb55b9 to
6a680a4
Compare
9b7d3a0 to
3885169
Compare
Removes xmodule/lti_block.py, xmodule/lti_2_util.py, all LTI JS/CSS/template assets, webpack entries, the USE_EXTRACTED_LTI_BLOCK toggle, and the conflicting `lti` entrypoint in pyproject.toml now that the extracted version in xblocks-contrib is the only implementation. Collapses toggle-conditional test classes into single test classes targeting the extracted-block behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3885169 to
0da9a28
Compare
Summary
Removes the built-in LTI XBlock from
xmodule/as part of the Slash-n-Burn Built-In XBlocks epic (#37819). The extracted version inxblocks-contribhas been the active implementation sinceUSE_EXTRACTED_LTI_BLOCKwas set toTrue(commitbcddf9cd53).Deleted:
xmodule/lti_block.py— built-in_BuiltInLTIBlockand shimxmodule/lti_2_util.py— LTI 2.0 utilities (now in xblocks-contrib)xmodule/tests/test_lti_unit.py,test_lti20_unit.py— built-in testsxmodule/js/src/lti/lti.js,xmodule/js/fixtures/lti.html— JS/fixturexmodule/static/css-builtin-blocks/LTIBlockDisplay.csslms/templates/lti.html,lms/templates/lti_form.html— built-in templatesModified:
openedx/envs/common.py— removedUSE_EXTRACTED_LTI_BLOCKtogglepyproject.toml— removed conflictingltientrypointwebpack.builtinblocks.config.js— removedLTIBlockDisplay/LTIBlockEditorentrieswebpack.common.config.js— removedimports-loaderrule forlti/lti.jslms/djangoapps/courseware/tests/test_block_render.py— import fromxblocks_contrib.ltilms/djangoapps/courseware/tests/test_lti_integration.py— removed toggle-conditional branches and duplicate test classes; removedimportlib.reload(lti_block)Note:
lms/djangoapps/lti_provider/(LTI protocol callback handler) is not in scope for this removal.Test plan
pytest lms/djangoapps/courseware/tests/test_lti_integration.py— should pass with singleTestLTIandTestLTIBlockListingclassespytest lms/djangoapps/courseware/tests/test_block_render.py— no LTI import errorsxblock.v1entrypoints:python -c "from xblocks_contrib.lti import LTIBlock; print(LTIBlock)"— should succeed🤖 Generated with Claude Code
Closes openedx/public-engineering#537