refactor: slash-and-burn Word Cloud BuiltIn XBlock#38745
refactor: slash-and-burn Word Cloud BuiltIn XBlock#38745irfanuddinahmad wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @irfanuddinahmad! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
db987da to
ed55494
Compare
905c461 to
19618f9
Compare
Removes the built-in Word Cloud XBlock and all associated assets now that USE_EXTRACTED_WORD_CLOUD_BLOCK has been True, making xblocks_contrib the active implementation. - Remove USE_EXTRACTED_WORD_CLOUD_BLOCK toggle from common.py - Remove word_cloud entrypoint from pyproject.toml - Delete xmodule/word_cloud_block.py (built-in class + shim) - Delete xmodule/assets/word_cloud/ (JS assets including D3 vendor libs and custom webpack config) - Delete lms/templates/word_cloud.html - Delete xmodule/static/css-builtin-blocks/WordCloudBlockDisplay.css - Remove WordCloudBlockDisplay/WordCloudBlockEditor webpack entries from webpack.builtinblocks.config.js and webpack.common.config.js - Delete xmodule/tests/test_word_cloud.py and lms/djangoapps/courseware/tests/test_word_cloud.py Closes openedx/public-engineering#534 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
19618f9 to
3313f57
Compare
Summary
Removes the built-in Word Cloud XBlock and all associated assets. The extracted
xblocks_contrib.word_cloud.WordCloudBlockhas been the active implementation sinceUSE_EXTRACTED_WORD_CLOUD_BLOCK = True.Step 2 of 8 in the Slash-n-Burn Built-In XBlocks epic.
Changes
USE_EXTRACTED_WORD_CLOUD_BLOCKtoggle fromopenedx/envs/common.pyword_cloudentrypoint frompyproject.tomlxmodule/word_cloud_block.pyxmodule/assets/word_cloud/(JS, D3 vendor libs, and customwebpack.config.js)lms/templates/word_cloud.htmlxmodule/static/css-builtin-blocks/WordCloudBlockDisplay.cssWordCloudBlockDisplay/WordCloudBlockEditorwebpack entries fromwebpack.builtinblocks.config.jsandwebpack.common.config.jsxmodule/tests/test_word_cloud.pyandlms/djangoapps/courseware/tests/test_word_cloud.pyTest plan
xmoduleunit tests:pytest xmodule/tests/npm run buildCloses openedx/public-engineering#534
Closes openedx/public-engineering#534