Skip to content

refactor: slash-and-burn Poll BuiltIn XBlock#38744

Open
irfanuddinahmad wants to merge 2 commits into
masterfrom
irfanuddinahmad/slash-and-burn-poll-block
Open

refactor: slash-and-burn Poll BuiltIn XBlock#38744
irfanuddinahmad wants to merge 2 commits into
masterfrom
irfanuddinahmad/slash-and-burn-poll-block

Conversation

@irfanuddinahmad

@irfanuddinahmad irfanuddinahmad commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the built-in Poll XBlock and all associated assets. The extracted xblocks_contrib.poll.PollBlock has been the default since USE_EXTRACTED_POLL_QUESTION_BLOCK was set to True, so the built-in implementation is now dead code.

Step 1 of 8 in the Slash-n-Burn Built-In XBlocks epic.

Changes

  • Remove USE_EXTRACTED_POLL_QUESTION_BLOCK toggle from openedx/envs/common.py
  • Remove poll_question entrypoint from pyproject.toml
  • Delete xmodule/poll_block.py (built-in class + shim)
  • Delete xmodule/js/src/poll/ (JS assets)
  • Delete lms/templates/poll.html
  • Delete xmodule/static/css-builtin-blocks/PollBlockDisplay.css
  • Remove PollBlockDisplay / PollBlockEditor webpack entries from webpack.builtinblocks.config.js and webpack.common.config.js
  • Delete xmodule/tests/test_poll.py (covered by xblocks-contrib tests)

Test plan

  • Run xmodule unit tests: pytest xmodule/tests/
  • Verify the Poll block still renders correctly in a course (smoke test using xblocks-contrib version)
  • Confirm webpack build succeeds: npm run build

Closes openedx/public-engineering#533

Closes openedx/public-engineering#533

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 11, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @irfanuddinahmad!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-poll-block branch from f3724d8 to 83ca0c7 Compare June 11, 2026 12:52
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 11, 2026
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-poll-block branch from 1b2c208 to dd15236 Compare June 12, 2026 11:52
Irfan Ahmad and others added 2 commits June 12, 2026 21:55
Removes the built-in Poll XBlock implementation and all associated assets
now that the extracted `xblocks_contrib.poll.PollBlock` is the default
(USE_EXTRACTED_POLL_QUESTION_BLOCK has been True since extraction).

- Remove USE_EXTRACTED_POLL_QUESTION_BLOCK toggle from common.py
- Remove poll_question entrypoint from pyproject.toml
- Delete xmodule/poll_block.py (built-in class + shim)
- Delete xmodule/js/src/poll/ (JS assets)
- Delete lms/templates/poll.html
- Delete xmodule/static/css-builtin-blocks/PollBlockDisplay.css
- Remove PollBlockDisplay/PollBlockEditor webpack entries
- Delete xmodule/tests/test_poll.py (covered by xblocks-contrib)

Closes openedx/public-engineering#533

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@irfanuddinahmad irfanuddinahmad force-pushed the irfanuddinahmad/slash-and-burn-poll-block branch from dd15236 to 155ae51 Compare June 12, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

[Refactor] Slash-n-Burn Poll BuiltIn XBlock

3 participants