fix: show name and description for legacy course roles listed in assignments - #200
fix: show name and description for legacy course roles listed in assignments#200dcoa wants to merge 2 commits into
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
+ Coverage 97.64% 97.66% +0.01%
==========================================
Files 68 68
Lines 1702 1711 +9
Branches 447 412 -35
==========================================
+ Hits 1662 1671 +9
Misses 40 40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a64a121 to
a0fc190
Compare
| disabled: true, | ||
| }, | ||
| { | ||
| role: 'ccx_coach', |
There was a problem hiding this comment.
I have a question about this role I check the backend ADR about the roles supported by the automatic migration https://github.com/openedx/openedx-authz/blob/main/docs/decisions/0011-course-authoring-migration-process.rst and CCX Coach is out of the scope. However, it is defined in the policy https://github.com/openedx/openedx-authz/blob/main/openedx_authz/constants/roles.py#L187. Because of this, I included but not sure if it is being returned.
There was a problem hiding this comment.
It was defined in the policy because of this error: openedx/openedx-authz#235. I remember we had a ccx role assignment in one of our sandboxes and it was shown empty in the list, so better to inlcude it.
a0fc190 to
d023d9f
Compare
Description
Course assignments can include roles that exist in openedx-authz but haven't been migrated to the permissions model yet: course_limited_staff, course_data_researcher, course_beta_tester and ccx_coach. They reach the admin console through assignments made elsewhere (legacy Instructor Dashboard, course-authoring migration), and the console had no metadata for them, so they rendered as blank rows:
This adds the missing metadata and renders it.
How to test
Related information