ci: bump Go, golangci-lint, codespell, and runners - #70
Conversation
|
CI bumps; easy to review; PTAL @opencontainers/cgroups-maintainers |
| fail-fast: false | ||
| matrix: | ||
| go-version: [1.24.x, 1.25.x] | ||
| go-version: [1.24.x, 1.26.x] |
There was a problem hiding this comment.
Can we just test oldstable and stable
| fail-fast: false | ||
| matrix: | ||
| go-version: [1.24.x, 1.25.x] | ||
| go-version: [1.24.x, 1.26.x] |
There was a problem hiding this comment.
| go-version: [1.24.x, 1.26.x] | |
| # the minimum version corresponds to go.mod | |
| go-version: [1.24.x, 1.26.x] |
There was a problem hiding this comment.
added
# Make sure to have version from go.mod included here.
@AkihiroSuda we also have to specify the version from go.mod, and in case this version is accidentally the same as "oldstable" or "stable", we have the test running twice on the same Go version. If we use numbers, we can clearly see if there's redundancy here. What do you think? |
* Test matrix: 1.24.x (go.mod minimum) and 1.26.x (latest); drop 1.25.x. * GO_VERSION for the validate jobs: 1.25 -> 1.26. * golangci-lint: v2.4 -> v2.12. * codespell: 2.4.1 -> 2.4.3. * Runners: ubuntu-24.04 -> ubuntu-26.04. The actions themselves are already kept current by dependabot. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
More arguments towards keeping the versions explicit (as opposed to using |
|
Yeah, pros and cons to each; for some repositories, I'm using Here's what I did on some of those repositories; Even if we decide not to use |
The actions themselves are already kept current by dependabot.