-
Notifications
You must be signed in to change notification settings - Fork 36
device-identity-provisioning: add keypair discovery and rename to Att… #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fdamato
wants to merge
3
commits into
opencomputeproject:main
Choose a base branch
from
fdamato:fadamato/device_identity_prov_attested_csr_discovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
80 changes: 80 additions & 0 deletions
80
specifications/device-identity-provisioning/cddl/attested-csr-eat.cddl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| ; An Attested CSR EAT is one of two variants: | ||
| ; - A CSR response, returned for a specific KeyPairID > 0. | ||
| ; - A keypair-inventory (discovery) response, returned when the | ||
| ; Requester specifies KeyPairID = 0. | ||
| cwt-attested-csr-eat = | ||
| cwt-attested-csr-eat-csr / | ||
| cwt-attested-csr-eat-inventory | ||
|
|
||
| cwt-attested-csr-eat-csr = { | ||
| ; Nonce claim is nonce-type = bstr .size (8..64) | ||
| &(nonce : 10) => bstr | ||
|
|
||
| ; Private Claims (they have to be < -65536 for rfc8392) | ||
|
|
||
| ; CSR bytestring | ||
| &(csr: -70001) => bstr | ||
|
|
||
| ; Derivation attributes, expressed as an OID -> bitfield map | ||
| &(attrib: -70002) => key-attributes-map | ||
| } | ||
|
|
||
| ; Discovery response payload returned when KeyPairID = 0 in the request. | ||
| cwt-attested-csr-eat-inventory = { | ||
| ; Nonce claim is nonce-type = bstr .size (8..64) | ||
| &(nonce : 10) => bstr | ||
|
|
||
| ; KeyPair Inventory private claim. Each entry pairs a KeyPairID | ||
| ; with the derivation-attribute bitfield map that applies to it. | ||
| &(keypair-inventory: -70003) => [+ keypair-inventory-entry] | ||
| } | ||
|
|
||
| keypair-inventory-entry = [ | ||
| keypair-id: 1..255, | ||
| attributes: key-attributes-map | ||
| ] | ||
|
|
||
| ; Derivation attributes are expressed as a map from an OID to a | ||
| ; bitfield. The OCP OID (ocp-security-dip-kda) is REQUIRED and maps to | ||
| ; the OCP derivation-component bitfield. Vendors MAY add additional | ||
| ; OIDs mapping to vendor-specific bitfields for derivation components | ||
| ; not covered by the OCP bitfield. | ||
| key-attributes-map = { | ||
| ocp-security-dip-kda => ocp-derivation-bitfield | ||
| * tagged-oid-type => uint | ||
| } | ||
|
|
||
| ; Tagged OID per RFC 9090. | ||
| tagged-oid-type = #6.111(bstr) | ||
|
|
||
| ; OID 1.3.6.1.4.1.42623.1.2 (ocp-security-dip-kda). | ||
| ocp-security-dip-kda = #6.111(h'2B0601040182CC7F0102') | ||
|
|
||
| ; OCP derivation-component bitfield. A set bit indicates that the | ||
| ; corresponding component contributed to the keypair's derivation. | ||
| ocp-derivation-bitfield = uint .bits ocp-derivation-components | ||
|
|
||
| ocp-derivation-components = &( | ||
| UDS: 0, | ||
| FIELD_ENTROPY: 1, | ||
| OWNER_PROVISIONED_NON_CONFIDENTIAL_FUSE: 2, | ||
| VENDOR_PROVISIONED_NON_CONFIDENTIAL_FUSE: 3, | ||
| FIRST_MUTABLE_CODE: 4, | ||
| RUNTIME_FIRMWARE: 5, | ||
| ) | ||
|
|
||
| signed-cwt = #6.18(COSE-Sign1-attested-csr) | ||
|
|
||
| COSE-Sign1-attested-csr = [ | ||
| protected: bstr .cbor protected-header-map | ||
| unprotected: {} | ||
| payload: bstr .cbor cwt-attested-csr-eat | ||
| signature: bstr | ||
| ] | ||
|
|
||
| protected-header-map = { | ||
| &(alg-id: 1) => int | ||
| &(content-type: 3) => tstr / int | ||
| &(issuer-key-id: 4) => bstr | ||
| } | ||
|
|
44 changes: 0 additions & 44 deletions
44
specifications/device-identity-provisioning/cddl/envelope-signed-csr-eat.cddl
This file was deleted.
Oops, something went wrong.
74 changes: 74 additions & 0 deletions
74
specifications/device-identity-provisioning/diag/attested-csr-eat-example.diag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| ; ---------------------------------------------------------------------- | ||
| ; Example: CSR response (returned when the Requester sent | ||
| ; GET_ATTESTED_CSR with a specific KeyPairID > 0). The payload | ||
| ; carries the CSR for the selected keypair along with the derivation- | ||
| ; attribute bitfield map that applies to it. | ||
| ; ---------------------------------------------------------------------- | ||
|
|
||
| signed-cwt / 18([ | ||
| / protected / <<{ | ||
| / alg-id / 1 : 7, | ||
| / content-type / 3 : "application/eat+cbor", | ||
| ; SHA-384 hash of the Attestation Key's certificate chain (same as | ||
| ; the SPDM DIGEST response) for the slot that produced this signature. | ||
| / kid / 4 : h'1a2b3c4d5e6f70819203a4b5c6d7e8f900112233445566778899aabbccddeeff00112233445566778899aabbccddeeff' | ||
| }>>, | ||
| / unprotected / {}, | ||
| / payload / <<{ | ||
| / nonce / 10: h'AAAABBBBCCCCDDDDEEEEFFFF0000111122223333444455556666777788889999', | ||
| / csr / -70001 : h'59025630820252308201d9a003020102021431a4e0', | ||
| ; Derivation attributes as an OID -> bitfield map. The single OCP | ||
| ; OID (1.3.6.1.4.1.42623.1.2) maps to the OCP bitfield. This CSR is | ||
| ; for the LDevID keypair (KeyPairID 2 in the discovery example): | ||
| ; UDS(bit 0) | FIELD_ENTROPY(bit 1) = 3 | ||
| / attrib / -70002: { | ||
| 111(h'2B0601040182CC7F0102') : 3 | ||
| } | ||
| }>>, | ||
| / signature / h'FA45AAB345AB4988' | ||
| ]) | ||
|
|
||
| ; ---------------------------------------------------------------------- | ||
| ; Example: discovery response (returned when the Requester sent | ||
| ; GET_ATTESTED_CSR with KeyPairID = 0). The payload omits the | ||
| ; CSR/attrib claims and instead carries the KeyPair Inventory claim, | ||
| ; which enumerates every supported KeyPairID and its derivation- | ||
| ; attribute bitfield map. | ||
| ; ---------------------------------------------------------------------- | ||
|
|
||
| signed-cwt / 18([ | ||
| / protected / <<{ | ||
| / alg-id / 1 : 7, | ||
| / content-type / 3 : "application/eat+cbor", | ||
| ; SHA-384 hash of the Attestation Key's certificate chain (same as | ||
| ; the SPDM DIGEST response) for the slot that produced this signature. | ||
| / kid / 4 : h'1a2b3c4d5e6f70819203a4b5c6d7e8f900112233445566778899aabbccddeeff00112233445566778899aabbccddeeff' | ||
| }>>, | ||
| / unprotected / {}, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| / payload / <<{ | ||
| / nonce / 10 : h'AAAABBBBCCCCDDDDEEEEFFFF0000111122223333444455556666777788889999', | ||
| / keypair-inventory / -70003 : [ | ||
| ; Each entry: [ KeyPairID, { OCP OID : bitfield } ]. | ||
| ; The single OCP OID is 1.3.6.1.4.1.42623.1.2. | ||
| ; Bitfields are cumulative: each key's bitfield includes the | ||
| ; derivation components inherited from its ancestor keys. | ||
| ; KeyPairID 1: IDevID, derived from UDS. | ||
| ; UDS(bit 0) = 1 | ||
| [ 1, { | ||
| 111(h'2B0601040182CC7F0102') : 1 | ||
| } ], | ||
| ; KeyPairID 2: LDevID, derived from IDevID + Field Entropy. | ||
| ; UDS(bit 0) | FIELD_ENTROPY(bit 1) = 3 | ||
| [ 2, { | ||
| 111(h'2B0601040182CC7F0102') : 3 | ||
| } ], | ||
| ; KeyPairID 3: derived from Owner-provisioned alias key + Field Entropy + UDS. | ||
| ; UDS(bit 0) | FIELD_ENTROPY(bit 1) | | ||
| ; OWNER_PROVISIONED_NON_CONFIDENTIAL_FUSE(bit 2) = 7 | ||
| [ 3, { | ||
| 111(h'2B0601040182CC7F0102') : 7 | ||
| } ] | ||
| ] | ||
| }>>, | ||
| / signature / h'FA45AAB345AB4988' | ||
| ]) | ||
18 changes: 0 additions & 18 deletions
18
specifications/device-identity-provisioning/diag/envelope-signed-csr-eat-example.diag
This file was deleted.
Oops, something went wrong.
File renamed without changes
File renamed without changes
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done