Skip to content

fix(scan): keep diff previews inside the repository - #372

Open
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/foo-2197-confine-legacy-diff-previews
Open

fix(scan): keep diff previews inside the repository#372
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/foo-2197-confine-legacy-diff-previews

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Apply the existing repository-scan path checks before generating changed-file previews.
  • Retain changed symlinks and other review items with an empty preview when their current worktree path cannot be read safely.
  • Preserve ordinary in-repository source previews and deleted-file review entries.
  • Add one focused, cross-platform regression using temporary synthetic fixtures.
  • Keep diff coverage expansion, submodule behavior, and preview orchestration unchanged.

Verification

  • pnpm dlx bun@1.3.14 test --timeout 30000 ./tests-ts/diff-rank-input.test.ts ./tests-ts/compact-diff-scan.test.ts — 6 tests and 44 assertions passed.
  • pnpm run types
  • pnpm run format
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai
mldangelo-oai requested a review from ianw-oai August 12, 2026 23:51
@github-actions github-actions Bot added the bug Something isn't working label Aug 12, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 1cf9c4cb5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Security Review

Here are some automated security review suggestions for this pull request.

Reviewed commit: 1cf9c4cb5e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Comment thread sdk/typescript/_bundled_plugin/scripts/generate_rank_input.py Outdated

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 53ad0168e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 53ad0168e4

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai
mldangelo-oai marked this pull request as ready for review August 13, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant