fix(windows): avoid unspawnable Deep Scan launchers - #367
Open
kmbroai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CODEX_CLI_PATHat the nested Deep Scan MCP environment boundary..cmdshims that require a shell, and protectedWindowsAppsbinaries.resolveCodexCommand()platform-binary resolver instead of adding another launcher resolver.Root cause
Deep Scan workers inherit
CODEX_CLI_PATHthrough the plugin MCP environment. Before this change, any non-empty value bypassed the canonical npm platform-binary resolver. On Windows that value can be the extensionless npm shim or a protected MSIXWindowsAppsexecutable;CodexExecpasses it directly tochild_process.spawnwithout a shell, which can fail withspawn EPERMeven when the installed@openai/codexplatform package contains a valid executable.This keeps case-insensitive Windows environment propagation intact, preserves explicit spawnable
.exe/.comlaunchers, and uses the existing bundled platform executable when the inherited value cannot be launched.Related: CLI-18410, codex#35872.
Validation
bun test tests-ts/runtime.test.ts --test-name-pattern 'bundled Codex through|explicit Codex executable override|spawnable Windows'— 3 passedpnpm run typespnpm run buildpnpm run formatpnpm pack --pack-destination ../../distpnpm run test:package— validated the installed package and a nested worker without globalcodexThe full
runtime.test.tsmodule was also attempted, but this host reports/and/homeas UID 65534, so 24 unrelated trusted-owner tests fail closed. The launcher-focused tests and package smoke pass without weakening those checks.