feat(desktop): Config tab to pin the oab-mcp target + reload core (UI) - #61
Closed
brettchien wants to merge 1 commit into
Closed
feat(desktop): Config tab to pin the oab-mcp target + reload core (UI)#61brettchien wants to merge 1 commit into
brettchien wants to merge 1 commit into
Conversation
The UI half for #60: a Config tab (cluster / AWS profile / region) that reads the persisted target via `mcp_target_get`, and on save calls `mcp_target_set` (persist + reload the core onto the new hermetic env), then refreshes the roster. Browser build disables the form. Ports #10's UI onto #60's provider-tagged `McpTarget` shape ({ provider: "ecs", cluster, profile?, region? }). Verified locally: `tsc --noEmit && vite build` clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI half of the oab-mcp target feature — stacked on #60 (
feat/mcp-target-hermetic, which adds the backend +mcp_target_get/mcp_target_setcommands). Base is #60's branch; will retarget tomainonce #60 merges.Finishes #10's intent (Config tab) on #60's provider-tagged design.
What
console/index.html+config.ts): cluster / AWS profile / region fields. Reads the persisted target viamcp_target_get; on save callsmcp_target_set(persist + reload the core onto the new hermetic env), then refreshes the roster. Browser build disables the form (no core).{ provider: "ecs", cluster, profile?, region? }— a future provider adds its own section.main.ts: oneinitConfigTab({ onSaved: () => void tick() })call at boot; tab-switching is already generic.styles.css: config form styling using existing theme tokens.Verification
tsc --noEmit && vite buildclean locally (46 modules, no type errors) — the TS/HTML/CSS is verified on this box (unlike src-tauri, which needs the macOS runner).bundle-macos.Sequence
bundle-macosis green.main, merge.🤖 Generated with Claude Code